Skip to content

chore(order2): improve accessibility #16893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rquartararo wants to merge 8 commits into
base: main
Choose a base branch
from
+164 −241
Open

chore(order2): improve accessibility #16893

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
307df97
fix: payment method tabbing
rquartararo Mar 3, 2026
31eeeac
chore: add missing aria labels
rquartararo Mar 4, 2026
7c6de9b
chore: make edit button accessible with enter
rquartararo Mar 4, 2026
0e173cf
fix: radio button accessibility
rquartararo Mar 5, 2026
a10b29a
test: fix tests
rquartararo Mar 5, 2026
5f37494
chore: add aria-expanded to payment methods
rquartararo Mar 5, 2026
cd6eeef
refactor: remove radio option row
rquartararo Mar 6, 2026
d53073b
chore: remove unneeded hover styles
rquartararo Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add missing aria labels
  • Loading branch information
@rquartararo
rquartararo committed Mar 4, 2026
commit 31eeeacbcdefcc758b2ee5ff9888ee19fa428a90
1 change: 1 addition & 0 deletions ...er2/Routes/Checkout/Components/DeliveryOptionsStep/Order2DeliveryOptionsCompletedView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export const Order2DeliveryOptionsCompletedView: React.FC<
textDecoration="underline"
cursor="pointer"
type="button"
aria-label="Edit shipping method"
onClick={onClickEdit}
>
<Text variant="sm" fontWeight="normal" color="mono100">
Expand Down
1 change: 1 addition & 0 deletions src/Apps/Order2/Routes/Checkout/Components/DeliveryOptionsStep/Order2DeliveryOptionsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ export const Order2DeliveryOptionsForm: React.FC<
}
>
<Clickable
aria-label="Shipping information"
height={20}
width={40}
ml={0.5}
Expand Down
2 changes: 2 additions & 0 deletions ...utes/Checkout/Components/FulfillmentDetailsStep/Order2FulfillmentDetailsCompletedView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export const Order2FulfillmentDetailsCompletedView: React.FC<
textDecoration="underline"
cursor="pointer"
type="button"
aria-label="Edit pickup details"
onClick={onClickEdit}
>
<Text variant="sm" fontWeight="normal" color="mono100">
Expand Down Expand Up @@ -76,6 +77,7 @@ export const Order2FulfillmentDetailsCompletedView: React.FC<
textDecoration="underline"
cursor="pointer"
type="button"
aria-label="Edit delivery address"
onClick={onClickEdit}
>
<Text variant="sm" fontWeight="normal" color="mono100">
Expand Down
1 change: 1 addition & 0 deletions ...ckout/Components/FulfillmentDetailsStep/SavedAddressOptions/Order2SavedAddressOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ export const SavedAddressOptions = ({

<Clickable
alignSelf="flex-start"
aria-label={`Edit address for ${address.name}`}
onClick={e => {
e.stopPropagation()
setUserAddressMode({
Expand Down
1 change: 1 addition & 0 deletions src/Apps/Order2/Routes/Checkout/Components/OfferStep/Order2OfferCompletedView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const Order2OfferCompletedView: React.FC<
textDecoration="underline"
cursor="pointer"
type="button"
aria-label="Edit offer amount"
onClick={onClickEdit}
>
<Text variant="sm" fontWeight="normal" color="mono100">
Expand Down
2 changes: 2 additions & 0 deletions src/Apps/Order2/Routes/Checkout/Components/Order2CollapsibleOrderSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ export const Order2CollapsibleOrderSummary: React.FC<
py={1}
px={2}
justifyContent="space-between"
aria-expanded={isExpanded}
aria-label="Toggle order summary"
>
{imageUrl && (
<RouterLink
Expand Down
1 change: 1 addition & 0 deletions src/Apps/Order2/Routes/Checkout/Components/PaymentStep/Order2PaymentCompletedView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const Order2PaymentCompletedView: React.FC<
textDecoration="underline"
cursor="pointer"
type="button"
aria-label="Edit payment method"
onClick={onClickEdit}
>
<Text variant="sm" fontWeight="normal" color="mono100">
Expand Down
2 changes: 1 addition & 1 deletion src/Apps/Order2/Routes/Checkout/Components/PaymentStep/StripePaymentCheckboxes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export const StripePaymentCheckboxes: React.FC<
days' notice. By clicking "Save bank account for later use",
you authorize Artsy to save the bank account specified above.`}
>
<Clickable ml={0.5} style={{ lineHeight: 0 }}>
<Clickable aria-label="Direct debit authorization information" ml={0.5} style={{ lineHeight: 0 }}>
Copy link
Contributor

@erikdstock erikdstock Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other areas with this icon on my recent radio groups PR I was able to remove the lineHeight style with no bad effect that I could see. Different context inside the payment step perhaps, or maybe i was missing something.

<InfoIcon />
</Clickable>
</Tooltip>
Expand Down