feat(retrieval): bound graph boost and explain misses [roadmap:retrieval-diagnostics] - #449
Merged
Merged
Conversation
…val-diagnostics] Implements decisions/roadmaps/retrieval-diagnostics.md. Signed-off-by: Tom Ballard <tom@armytage.co>
6 tasks
Signed-off-by: Tom Ballard <tom@armytage.co>
…gnostics] Signed-off-by: Tom Ballard <tom@armytage.co>
…stics] Signed-off-by: Tom Ballard <tom@armytage.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
decisions/roadmaps/retrieval-diagnostics.md.Adds:
decided diagnose <query> <target>for deterministic named-target miss tracesRoadmap / ADR Trace
Roadmap:
decisions/roadmaps/retrieval-diagnostics.mdRequirements:
decisions/requirements/rac-floor-ratio-boost-gate.mddecisions/requirements/rac-explain-miss-diagnostics.mdRelevant ADRs:
decisions/decisions/adr-002-ai-optional.mddecisions/decisions/adr-007-json-contract-stability.mddecisions/decisions/adr-037-token-boundary-search-matching.mddecisions/decisions/adr-038-body-text-search-tier.mddecisions/decisions/adr-066-deterministic-grounding-eval.mddecisions/decisions/adr-078-deterministic-relevance-ranking.mdScope
Included
graph_floor_ratioandgraph_gateinfind --explainExcluded
findoutput when--explainis absentProduct / Architecture Decisions
graph_floor=0.85, so stale indexes rebuild instead of silently retaining the old ranking contract.User-Facing Contract
CLI
diagnoseaccepts the same type, tag, liveness, and traversal filters used byfind.Human Output
The trace names the target, outcome, reason, rank, matched and missing terms, and artifacts surfaced ahead when applicable.
JSON Output
The new payload reports
query,target,outcome,reason,surface_limit,match_count, term evidence, rank, and the explained artifact. Existingfind --json --explaincomponents gaingraph_floor_ratioandgraph_gate.Exit Codes
0: the named target was diagnosed1: the target is missing or ambiguous2: arguments or directory are invalidVerification
Ran
decided validate decisions/— 451 valid artifacts, 0 invaliddecided relationships decisions/ --validate— 2,694 relationships, 0 validation issuesdecided review decisions/— no priority 1–2 findings; existing lower-priority review debt remainsgit diff --checkGitHub Actions is green. PR Checks run #502 passed, and Rust workflow run #174 passed the release workspace tests, strict Clippy, formatting, macOS and Windows runtime smokes, dependency policy, contract vectors, and live-corpus invariants.
Covered
Review Path
Suggested order:
resolve.rs, output and CLI wiring, CLI/unit tests, index fingerprint and contract vector, then corpus and user documentation.Notes For Reviewer
The companion benchmark PR adds four black-box component cases and two downstream DecisionGrounding scenarios. It must consume a published v0.28.0 binary before its release-dependent checks can pass.