Skip to content

Add option to temporarily disable reshimming #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vic merged 2 commits into from
Jan 23, 2019
Merged

Add option to temporarily disable reshimming #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
441d9f8
add option to temporarily disable reshimming
lukaselmer Jan 23, 2019
9975c20
document reshim skipping
lukaselmer Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ request
express
```

## Temporarily disable reshimming

To avoid a slowdown when installing large packages (see https://github.com/asdf-vm/asdf-nodejs/issues/46), you can `ASDF_SKIP_RESHIM=1 npm i -g <package>` and reshim after installing all packages using `asdf reshim nodejs`.

## Using a dedicated OpenPGP keyring

The `gpg` commands above imports the OpenPGP public keys in your main OpenPGP keyring. However, you can also use a dedicated keyring in order to mitigate [this issue](https://github.com/nodejs/node/issues/9859).
Expand Down
3 changes: 2 additions & 1 deletion bin/install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,4 +277,5 @@ tmp_download_dir="$(mktemp -d -t 'asdf_nodejs_XXXXXX')"
trap 'rm -rf "${tmp_download_dir}"' EXIT

install_nodejs "$ASDF_INSTALL_TYPE" "$ASDF_INSTALL_VERSION" "$ASDF_INSTALL_PATH" "$tmp_download_dir"
install_default_npm_packages
ASDF_SKIP_RESHIM=1 install_default_npm_packages
asdf reshim nodejs "$ASDF_INSTALL_VERSION"
6 changes: 5 additions & 1 deletion bin/postinstall
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
#!/usr/bin/env bash

asdf reshim nodejs "${ASDF_INSTALL_VERSION:-$npm_config_node_version}"
if [ "$ASDF_SKIP_RESHIM" == "1" ]; then
echo "Run 'asdf reshim nodejs ${ASDF_INSTALL_VERSION:-$npm_config_node_version}' after installing the packets to reshim"
else
asdf reshim nodejs "${ASDF_INSTALL_VERSION:-$npm_config_node_version}"
fi