Reshim only when needed

[lukaselmer]

• Only reshims when npm packets are installed which have a binary
• I didn't find any documentation about the env variable npm_package_bin_*, but it seems that it is always npm_package_bin_<bin_name>, e.g. npm_package_bin_prettier for the package prettier
• As pointed out by @augustobmoura, the documentation is here

[minusfive]

Wondering whether there are plans to merge this, or is there another solution to npm i -g in the works? Prepending the ENV var from #117 every time feels pretty hacky.

[surajbarkale]

I had to replace this line with elif /usr/bin/env | grep -q "npm_package_bin_"; then for it to work.

[MrQubo]

@minusfive You can add this to .bashrc, or equivalent if using shell other than bash.

[Stratus3D]

I am not very familiar with this functionality, so I can't really review this PR for correctness. If any other contributors to asdf-nodejs have any thoughts on this please let me know.

[homburg]

This seems to work correctly.

If @surajbarkale suggestion is included and merge conflicts are resolved, I'd vote for merging this.

[augustobmoura]

The documentation is here, it only adds npm_package_bin_{executable} because the packages have a bin section in their package.json (every entry in the bin object will get a variable), which in turns means that it will add a global command that needs reshimming.

Would be better if the reshim only occurred after the last install, I will see if something can be done about that. The reshimming only on binaries is a advance anyways, @lukaselmer can you solve the issues with the PR? Or can we open another one?

[augustobmoura]

#197 does something similar, but uses npm_config_argv that contains the original arguments from the install/uninstall command, if the package name is in the argument list the reshim is run

[lukaselmer]

@augustobmoura I resolved the merge conflict, and I like #197 👍

[augustobmoura]

After changing the auto reshim mechanism in #232, this PR is probably deprecated. Thanks for the work anyways @lukaselmer!