generated from aspect-extensions/extension-template
-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Description
The CI test in example/README.md has never passed because it checks for output that the script doesn't produce.
Current Behavior
The test in example/README.md expects the output to contain "SUCCESS":
echo "${output}" | grep -q "SUCCESS" || {
echo >&2 "Wanted output containing 'SUCCESS' but got '${output}'"
exit 1
}However, bazel-diff.axl never outputs "SUCCESS". The script outputs messages like:
- "Building //tools:bazel-diff executable..."
- "Checking out merge base..."
- "Generating Hashes for Base Revision..."
- "Restoring current revision..."
- "Diffing Hashes..."
- "Impacted Targets for Revision..."
Expected Behavior
The CI test should check for output that the script actually produces.
Proposed Solution
Update the test to grep for "Impacted Targets" (the final message the script outputs on success) instead of "SUCCESS".
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels