Skip to content

Update unit test to avoid deprecated ExpectedException.none() by using Assert.assertThrows() #275

@miurahr

Description

@miurahr

ExpectedException.none() is marked as deprecated but there are so many unit tests which depends on the function.
These cases can be rewritten by using Assert.assertThrows(Class<?> class, ThrowableRunnable run)

There are also Similar deprecation; expectIllegalStateIsNotShowingComponent and expectIllegalStateIsDisabledComponent

These can be implemented as like as followings;


  public static AbstractStringAssert<?> assertThatIllegalStateExceptionCauseIsDisabledComponent(ThrowingRunnable r) {
      Throwable t = Assert.assertThrows(IllegalStateException.class, r);
      return assertThat(t.getMessage()).contains("Expecting component").contains("to be enabled");
  }

  public static AbstractStringAssert<?> assertThatIllegalStateExceptionCauseIsNotShowingComponent(ThrowingRunnable r) {
      Throwable t = Assert.assertThrows(IllegalStateException.class, r);
      return assertThat(t.getMessage()).contains("Expecting component").contains("to be shown on the screen");
  }
  public static AbstractStringAssert<?> assertThatIllegalStateExceptionCauseIsNotResizableComponent(ThrowingRunnable runnable) {
    Throwable t = Assert.assertThrows(IllegalStateException.class, runnable);
    return assertThat(t.getMessage()).contains("Expecting component").contains("to be resizable by the user");
  }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions