This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(rollup): allow specfiying full filter directives in logs#174
Open
SuperFluffy wants to merge 1 commit into
Open
fix(rollup): allow specfiying full filter directives in logs#174SuperFluffy wants to merge 1 commit into
SuperFluffy wants to merge 1 commit into
Conversation
aajimal
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the pre-set
astria-conductor=andastria-composer=prefixes in the*-LOGenv vars set for conductor and composer.The environment variables
ASTRIA_CONDUCTOR_LOGandASTRIA_COMPOSER_LOGdon't merely allow setting log levels but allow much more expressive filtering of targets (like modules), span names, span-fields or values of span-fields.For example, I used the following filter directives to test changes to conductor: