Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(rollup): allow specfiying full filter directives in logs#174

Open
SuperFluffy wants to merge 1 commit into
mainfrom
superfluffy/filter-directives-not-log-level
Open

fix(rollup): allow specfiying full filter directives in logs#174
SuperFluffy wants to merge 1 commit into
mainfrom
superfluffy/filter-directives-not-log-level

Conversation

@SuperFluffy
Copy link
Copy Markdown
Contributor

This patch removes the pre-set astria-conductor= and astria-composer= prefixes in the *-LOG env vars set for conductor and composer.

The environment variables ASTRIA_CONDUCTOR_LOG and ASTRIA_COMPOSER_LOG don't merely allow setting log levels but allow much more expressive filtering of targets (like modules), span names, span-fields or values of span-fields.

For example, I used the following filter directives to test changes to conductor:

filterDirectives: "[{config}]=info,[{sequencer_block.height=1951}]=info,[{reconstructed_block.height=1951}]=info,[{block.height=1951}]=info"

@SuperFluffy SuperFluffy requested review from a team and joroshiba February 5, 2024 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants