Enable tests on CI#357
Conversation
|
Some tests seem broken (because they were merged without being tested on CI). |
| }) | ||
| } | ||
|
|
||
| #[ignore] |
There was a problem hiding this comment.
This assertion is failed:
Line 57 in ca80ca9
Error:
---- test_buffered_writer_inner_into_inner_does_not_flush stdout ----
thread 'test_buffered_writer_inner_into_inner_does_not_flush' panicked at 'assertion failed: `(left == right)`
left: `[0, 1]`,
right: `[]`', tests/buf_writer.rs:57:9
I think this is because #315 changed the behavior of lnto_inner: https://github.com/async-rs/async-std/pull/315/files#diff-a2b217372e599101d2b0f1dbab63ee2eR205
taiki-e
force-pushed
the
tests
branch
2 times, most recently
from
f54f132 to
cf1bcc6
Compare
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Thanks for fixing the test!
I just have one request: could you rename test_buffered_writer_inner_into_inner_does_not_flush to test_buffered_writer_inner_into_inner_flushes? :)
Feel free to merge the PR after the change.
Done.
I don't have merge right... |
1 participant
As mentioned in #286 (comment), if cargo test contains --doc arguments, only doc test is executed.