Conversation
AayushSaini101
requested review from
AGurlhosur,
JEFFLUFC,
KieranM1999,
asyncapi-bot-eve,
dalelane,
dan-r and
lewis-relph
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
AayushSaini101
changed the title
fmvilas
left a comment
fmvilas
left a comment
There was a problem hiding this comment.
LGTM but I'm not a code owner. A part of me doesn't believe it's that easy 😄 I hope it is! It would be mean we did a great job 😄
|
@AayushSaini101 did you test this change? I mean after just changing the version, did you try to run code generation with such change? I would be surprised if that is enough to make template support v3 |
|
I think more is needed than this. I've tried to make a start in moving this forward in #186 but I still don't think the work is complete even with that. |
|
closing in favour of #186 |
5 participants
Resolve: #118