Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fix hyperlink highlighting#76

Merged
rafeca merged 1 commit into
atom:masterfrom
Aerijo:master
Jun 12, 2019
Merged

Fix hyperlink highlighting#76
rafeca merged 1 commit into
atom:masterfrom
Aerijo:master

Conversation

@Aerijo
Copy link
Copy Markdown
Contributor

@Aerijo Aerijo commented Jun 12, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Changes the regex to a string, which is then turned into a regex itself later on.

Alternate Designs

na

Benefits

correctness

image

Possible Drawbacks

na

Applicable Issues

fixes #75

@Aerijo
Copy link
Copy Markdown
Contributor Author

Aerijo commented Jun 12, 2019

image

Looks like CSON and regex don't mix as expected. The fact that so much wrong still ends up "right" is amusing. Like, why would anyone want an object passed to a regex constructor to make a regex with the default object string, that happens to form the regex pattern to match any character in object Object.

Copy link
Copy Markdown
Contributor

@rafeca rafeca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a fix so quickly!! 😍

@rafeca rafeca merged commit a80efcb into atom:master Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax highlighting of package.json after upgrading to 1.38.0 is distracting and inconsistent

4 participants