This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Improve HTML (Ruby - ERB) grammar #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grammars/html (ruby - erb).cson
Outdated
Contributor
There was a problem hiding this comment.
To make this consistent with other languages, I'd suggest using source.ruby.embedded.erb instead. Ditto below.
Author
|
Improvements suggested applied. |
winstliu
pushed a commit
that referenced
this pull request
Nov 18, 2015
Improve HTML (Ruby - ERB) grammar
Contributor
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114 (Embedded Ruby's scope).
It also fixes closing ERBs tags being considered two separate tokens, and includes some basic tests.