Merged
Conversation
Respect `data-dir` There are only global `data-files` Add `getDataFileName` to generated `Paths_` module Better parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, I just wanted to add
getDataFileName :: FilePath -> IO FilePathto the autogeneratedPaths_*modules, but that lead to me finding a bunch of other problems, which I also fixed.Changes
getDataFileName :: FilePath -> IO FilePathto the autogeneratedPaths_*modules.data-files. This means that installing them doesn't have to be done separately for every section.data-dirwas ignored, leading tomcabalnot finding the data files. Only try to copy files when there are matching files, otherwisetarthrows an error.install-includesandc-sources.VItem <$> pItemfor fields that are URLs, directories or fixed names. This makes the parser accept less invalid input and avoids a trailing newline.With this change, the
js-dgtable,js-flot, andjs-jquerypackages can be successfully installed.