Skip to content

Avoid default service crash without bundle identifier #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fhwvtqdc2q-svg wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −4
Open

Avoid default service crash without bundle identifier #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
445afd4
Avoid crashing when bundle identifier is unavailable
fhwvtqdc2q-svg May 16, 2026
1e95cdc
Cover default service fallback
fhwvtqdc2q-svg May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SimpleKeychain/SimpleKeychain.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public struct SimpleKeychain: @unchecked Sendable {
/// - Parameter synchronizable: Whether the items should be synchronized through iCloud. Defaults to `false`.
/// - Parameter attributes: Additional attributes to include in every query. Defaults to an empty dictionary.
/// - Returns: A ``SimpleKeychain`` instance.
public init(service: String = Bundle.main.bundleIdentifier!,
public init(service: String = Bundle.main.bundleIdentifier ?? "SimpleKeychain",
accessGroup: String? = nil,
accessibility: Accessibility = .afterFirstUnlock,
accessControlFlags: SecAccessControlCreateFlags? = nil,
Expand All @@ -61,7 +61,7 @@ public struct SimpleKeychain: @unchecked Sendable {
/// - Parameter synchronizable: Whether the items should be synchronized through iCloud. Defaults to `false`.
/// - Parameter attributes: Additional attributes to include in every query. Defaults to an empty dictionary.
/// - Returns: A ``SimpleKeychain`` instance.
public init(service: String = Bundle.main.bundleIdentifier!,
public init(service: String = Bundle.main.bundleIdentifier ?? "SimpleKeychain",
accessGroup: String? = nil,
accessibility: Accessibility = .afterFirstUnlock,
accessControlFlags: SecAccessControlCreateFlags? = nil,
Expand Down
3 changes: 1 addition & 2 deletions SimpleKeychainTests/SimpleKeychainSpec.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class SimpleKeychainTests: XCTestCase {

func testInitializationWithDefaultValues() {
XCTAssertEqual(sut.accessGroup, nil)
XCTAssertEqual(sut.service, Bundle.main.bundleIdentifier)
XCTAssertEqual(sut.service, Bundle.main.bundleIdentifier ?? "SimpleKeychain")
XCTAssertEqual(sut.accessibility, Accessibility.afterFirstUnlock)
XCTAssertEqual(sut.accessControlFlags, nil)
XCTAssertEqual(sut.isSynchronizable, false)
Expand Down Expand Up @@ -374,4 +374,3 @@ public extension Dictionary where Key == String, Value == Any {
public func ==(lhs: [String: Any], rhs: [String: Any]) -> Bool {
return NSDictionary(dictionary: lhs).isEqual(to: rhs)
}