Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
- Coverage 80.16% 80.07% -0.09%
==========================================
Files 152 152
Lines 6090 6098 +8
Branches 1244 1247 +3
==========================================
+ Hits 4882 4883 +1
- Misses 693 698 +5
- Partials 515 517 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ankita10119
left a comment
ankita10119
left a comment
There was a problem hiding this comment.
Could you add a unit test for the new error handling path in withErrorHandling, following the same pattern as the existing tests in prompts.tests.ts? Also, was this tested on a tenant with and without passkeys enabled ?
| "format": "npx prettier --write .", | ||
| "test": "ts-mocha -p tsconfig.json --recursive 'test/**/*.test*' --exclude 'test/e2e/*' --timeout 20000", | ||
| "test:e2e:node-module": "ts-mocha -p tsconfig.json --recursive 'test/e2e/*.test*' --timeout 120000", | ||
| "test:e2e:node-module": "ts-mocha -p tsconfig.json --recursive 'test/e2e/*.test*' --timeout 150000", |
There was a problem hiding this comment.
Any reason for this change?
| mfa-login-options: | ||
| pageTitle: 'Log in to ${clientName}' | ||
| authenticatorNamesSMS: 'SMS' | ||
| passkeys: |
There was a problem hiding this comment.
Could you please add the passkeys examples alongside the existing content rather than replacing it? Some useful examples like login, signup, mfa, and the filters block seem to have been removed unintentionally
3 participants
🔧 Changes
Add support of passkeys in prompt partials
📚 References
https://auth0.com/docs/api/management/v2/prompts/get-partials
https://auth0.com/docs/api/management/v2/prompts/put-partials
🔬 Testing
Added unit tests
📝 Checklist