fix: action module fetching logic to resolve correct module IDs#1340
Open
kushalshit27 wants to merge 4 commits intomasterfrom
Open
fix: action module fetching logic to resolve correct module IDs#1340kushalshit27 wants to merge 4 commits intomasterfrom
kushalshit27 wants to merge 4 commits intomasterfrom
Conversation
- src/tools/auth0/handlers/actions.ts: simplify module fetching logic by removing redundant checks for actionModules - test/tools/auth0/handlers/actions.tests.js: add test to ensure modules are fetched from API even when actionModules are provided
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
+ Coverage 80.18% 80.23% +0.05%
==========================================
Files 152 152
Lines 6101 6102 +1
Branches 1247 1247
==========================================
+ Hits 4892 4896 +4
+ Misses 693 692 -1
+ Partials 516 514 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
actionModuleswere present in the local assets (e.g. loaded from directory/YAML config), the handler would use those local module objects directly instead of fetching from the Auth0 Management API. Local config module objects do not carryidfields, causingmodule_idandmodule_version_idto be set to incorrect or empty values when deploying actions that reference action modules.📚 References
🔬 Testing
📝 Checklist