Skip to content

Set explicit type for .other in switch in FlutterError#808

Merged
sanchitmehtagit merged 4 commits intoauth0:mainfrom
crazycatk:fix-unambiguous-call-to-other-error
Apr 12, 2026
Merged

Set explicit type for .other in switch in FlutterError#808
sanchitmehtagit merged 4 commits intoauth0:mainfrom
crazycatk:fix-unambiguous-call-to-other-error

Conversation

@crazycatk
Copy link
Copy Markdown
Contributor

  • [N/A] All new/changed/fixed functionality is covered by tests (or N/A)
  • [N/A] I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Added an explicit type in WebAuthExtension.swift to the .other switch case to avoid swift compiler error:

[ +6 ms] Failed to build iOS app
[ +41 ms] Swift Compiler Error (Xcode): Ambiguous use of 'other'
/Users/artemzelinskyi/.pub-cache/hosted/pub.dev/auth0_flutter-2.0.0/darwin/Classes/WebAuth/WebAuthExtensions.swift:19:14

In xcode version 26.4

🎯 Testing

  1. Update xcode to latest version.
  2. Add plugin to the flutter app.
  3. Try building app for ios
  4. Get a " Swift Compiler Error (Xcode): Ambiguous use of 'other'" error

Reproducible on both 2.1.0-beta.1 and 2.0.0

@pmathew92
Copy link
Copy Markdown
Contributor

Hi @crazycatk ,
Thanks for raising this PR. We will review this and get back to you.

Comment thread auth0_flutter/darwin/Classes/WebAuth/WebAuthExtensions.swift
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.82%. Comparing base (253209a) to head (2996a3a).
⚠️ Report is 385 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #808       +/-   ##
=============================================
- Coverage     96.08%   77.82%   -18.27%     
=============================================
  Files            97      136       +39     
  Lines          1611     2530      +919     
  Branches        331      600      +269     
=============================================
+ Hits           1548     1969      +421     
- Misses           49      531      +482     
- Partials         14       30       +16     
Flag Coverage Δ
auth0_flutter 86.74% <ø> (-13.26%) ⬇️
auth0_flutter_android 77.49% <ø> (-19.07%) ⬇️
auth0_flutter_ios 74.29% <100.00%> (-25.56%) ⬇️
auth0_flutter_platform_interface 82.77% <ø> (-4.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanchitmehtagit
Copy link
Copy Markdown
Contributor

crazycatk could we sign the commits

@crazycatk crazycatk force-pushed the fix-unambiguous-call-to-other-error branch 3 times, most recently from d723942 to 859b7f6 Compare April 9, 2026 10:49
@sanchitmehtagit sanchitmehtagit merged commit e3a5e23 into auth0:main Apr 12, 2026
14 of 16 checks passed
This was referenced Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants