Set explicit type for .other in switch in FlutterError#808
Merged
sanchitmehtagit merged 4 commits intoauth0:mainfrom Apr 12, 2026
Merged
Set explicit type for .other in switch in FlutterError#808sanchitmehtagit merged 4 commits intoauth0:mainfrom
sanchitmehtagit merged 4 commits intoauth0:mainfrom
Conversation
Contributor
|
Hi @crazycatk , |
NandanPrabhu
reviewed
Apr 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
=============================================
- Coverage 96.08% 77.82% -18.27%
=============================================
Files 97 136 +39
Lines 1611 2530 +919
Branches 331 600 +269
=============================================
+ Hits 1548 1969 +421
- Misses 49 531 +482
- Partials 14 30 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
crazycatk could we sign the commits |
d723942 to
859b7f6
Compare
sanchitmehtagit
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
Added an explicit type in WebAuthExtension.swift to the .other switch case to avoid swift compiler error:
[ +6 ms] Failed to build iOS app
[ +41 ms] Swift Compiler Error (Xcode): Ambiguous use of 'other'
/Users/artemzelinskyi/.pub-cache/hosted/pub.dev/auth0_flutter-2.0.0/darwin/Classes/WebAuth/WebAuthExtensions.swift:19:14
In xcode version 26.4
🎯 Testing
Reproducible on both 2.1.0-beta.1 and 2.0.0