Skip to content

fix: shuffle to undo unique sort#406

Merged
mfeurer merged 2 commits intomainfrom
fix-shuffle-to-undo-unique-sort
Jul 28, 2025
Merged

fix: shuffle to undo unique sort#406
mfeurer merged 2 commits intomainfrom
fix-shuffle-to-undo-unique-sort

Conversation

@eddiebergman
Copy link
Contributor

@LukasFehring Anyone going to take over on ConfigSpace from Hannover side? I'm not supported to really maintain ConfigSpace as I've left AutoML.org

@thijssnelleman
Copy link
Collaborator

@mfeurer I don't think I can contribute to this PR, it looks logical to me but I do not understand the full context.

@eddiebergman
Copy link
Contributor Author

It's mergable, you can view the issue it's derived from and that it fixed the users issue.

Essentially, the sampling procedure would require doing a check "have we already sampled this value", which is much cheaper to check when sorted. However this sorting ended up biasing the sample, as we returned the first n samples, i.e. the first n samples according to order, instead of a random n samples around the distribution

@LukasFehring
Copy link

Sorry, for some reason i got no notification on this branch :)
The short answer is that I do not have the capacity to work on ConfigSpace

@thijssnelleman
Copy link
Collaborator

Alright, sounds good to me. @mfeurer I think with your approval this can be merged.

@mfeurer mfeurer merged commit 833f4cf into main Jul 28, 2025
15 of 17 checks passed
@mfeurer mfeurer deleted the fix-shuffle-to-undo-unique-sort branch July 28, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Neighbour Values of Integer Hyperparameter are not Symmetric

4 participants