Conversation
|
@mfeurer I don't think I can contribute to this PR, it looks logical to me but I do not understand the full context. |
|
It's mergable, you can view the issue it's derived from and that it fixed the users issue. Essentially, the sampling procedure would require doing a check "have we already sampled this value", which is much cheaper to check when sorted. However this sorting ended up biasing the sample, as we returned the first |
|
Sorry, for some reason i got no notification on this branch :) |
|
Alright, sounds good to me. @mfeurer I think with your approval this can be merged. |
@LukasFehring Anyone going to take over on
ConfigSpacefrom Hannover side? I'm not supported to really maintainConfigSpaceas I've left AutoML.org