feat(autoware_lanelet2_map_visualizer): add new maker by yuki-takagi-66 · Pull Request #828 · autowarefoundation/autoware_core

yuki-takagi-66 · 2026-02-03T06:25:37Z

Description

add new maker type for obstacle_removal_area

How was this PR tested?

visualized as the following:

Notes for reviewers

New released version of lanelet2extension is required

Interface changes

None.

Effects on system behavior

None.

github-actions · 2026-02-03T06:25:47Z

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

You've checked our contribution guidelines.
Your PR follows our pull request guidelines.
All required CI checks pass before marking the PR ready for review.

sasakisasaki

Reviewed code and the test result looks good 👍

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

codecov · 2026-02-18T10:26:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.75%. Comparing base (a013124) to head (656f401).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   50.74%   50.75%           
=======================================
  Files         348      348           
  Lines       22529    22533    +4     
  Branches    10067    10071    +4     
=======================================
+ Hits        11433    11437    +4     
  Misses       9999     9999           
  Partials     1097     1097

Flag	Coverage Δ		*Carryforward flag
daily-humble	`50.55% <ø> (-0.02%)`	⬇️	Carriedforward from a013124
daily-jazzy	`50.00% <ø> (ø)`		Carriedforward from a013124
differential-humble	`6.89% <100.00%> (?)`
total	`50.18% <ø> (ø)`		Carriedforward from a013124
total-humble	`50.54% <ø> (ø)`		Carriedforward from a013124
total-jazzy	`50.00% <ø> (ø)`		Carriedforward from a013124

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xmfcx · 2026-02-20T12:50:43Z

Why was this merged when https://github.com/autowarefoundation/autoware_core/actions/runs/22088376814 has failed?

https://github.com/autowarefoundation/autoware_core/actions/runs/22088376814/job/63827899733#step:14:1561

/__w/autoware_core/autoware_core/map/autoware_lanelet2_map_visualizer/src/lanelet2_map_visualization_node.cpp: In member function ‘void autoware::lanelet2_map_visualizer::Lanelet2MapVisualizationNode::on_map_bin(autoware_map_msgs::msg::LaneletMapBin_<std::allocator<void> >::ConstSharedPtr)’:
/__w/autoware_core/autoware_core/map/autoware_lanelet2_map_visualizer/src/lanelet2_map_visualization_node.cpp:331:48: error: ‘obstacleRemovalAreaAsMarkerArray’ is not a member of ‘lanelet::visualization’
  331 |     &map_marker_array, lanelet::visualization::obstacleRemovalAreaAsMarkerArray(
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I get the same error when building nightly.

I know that these following prs are necessary:

But they should be merged, the new docker image should be built, then this CI would pass.

~~Right now autoware nightly is not building because this was merged with bypassing the CI requirements.~~

xmfcx · 2026-02-20T12:56:15Z

I'm sorry this was merged with feat(repositories/autoware.repos): minor update autowarefoundation/autoware_lanelet2_extension to 0.12.0 autoware#6824

It was my fault for not pulling the autoware.repos first.

But still, please don't override the CI unless there is an emergency or something.

mitsudome-r · 2026-02-20T13:09:47Z

@xmfcx
I don't think it was merged with by-pass merge. The final results were passing:
https://github.com/autowarefoundation/autoware_core/actions/runs/22135634335

xmfcx · 2026-02-20T13:17:41Z

So weird, when I clicked Checks -> build-test-tidy-pr link, it redirected me to the failing CI page which was https://github.com/autowarefoundation/autoware_core/actions/runs/22088376814 but now it redirects to the correct page as yours. I'm a bit confused on how it happened.

Oh now I see, there are 2 entries in this page: https://github.com/autowarefoundation/autoware_core/pull/828/checks

I'm not sure why the duplicates are there.

There were 4 run retries but 2 are visible there. One for the first run, one for the last one.

Sorry for all the commotion lol.

…tion#828) * add maker --------- Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp> Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>

…tion#828) * add maker --------- Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

feat(autoware_lanelet2_map_visualizer): add new maker (autowarefoundation#828)

yuki-takagi-66 mentioned this pull request Feb 3, 2026

feat(visualzer): add new maker type autowarefoundation/autoware_lanelet2_extension#96

Merged

yuki-takagi-66 marked this pull request as ready for review February 3, 2026 06:27

yuki-takagi-66 requested review from a team, Motsu-san, TaikiYamada4, YamatoAndo and soblin as code owners February 3, 2026 06:27

yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 3, 2026

soblin approved these changes Feb 3, 2026

View reviewed changes

sasakisasaki self-assigned this Feb 4, 2026

sasakisasaki approved these changes Feb 4, 2026

View reviewed changes

yuki-takagi-66 force-pushed the takagi/add-map_area_filter-maker branch from 318ca48 to 1208ff7 Compare February 16, 2026 09:47

yuki-takagi-66 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 16, 2026

yuki-takagi-66 mentioned this pull request Feb 16, 2026

rafactor: refactor launch architecture tier4/map_area_filter#11

Merged

yuki-takagi-66 added 2 commits February 17, 2026 15:30

add maker

8efb51b

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

change tag name

656f401

Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

yuki-takagi-66 force-pushed the takagi/add-map_area_filter-maker branch from 1208ff7 to 656f401 Compare February 17, 2026 06:30

yuki-takagi-66 mentioned this pull request Feb 17, 2026

feat(visualizer): change a tag name; map_are_filter to obstacle_removal_area autowarefoundation/autoware_lanelet2_extension#100

Merged

soblin approved these changes Feb 17, 2026

View reviewed changes

mitsudome-r mentioned this pull request Feb 18, 2026

feat(repositories/autoware.repos): minor update autowarefoundation/autoware_lanelet2_extension to 0.12.0 autowarefoundation/autoware#6824

Merged

yuki-takagi-66 added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Feb 18, 2026

yuki-takagi-66 merged commit e157e16 into autowarefoundation:main Feb 19, 2026
76 of 88 checks passed

yuki-takagi-66 deleted the takagi/add-map_area_filter-maker branch February 19, 2026 06:42

yuki-takagi-66 added a commit to tier4/autoware_core that referenced this pull request Mar 11, 2026

feat(autoware_lanelet2_map_visualizer): add new maker (autowarefounda…

f16a4fe

…tion#828) * add maker --------- Signed-off-by: yuki-takagi-66 <yuki.takagi@tier4.jp>

yuki-takagi-66 mentioned this pull request Mar 11, 2026

feat(autoware_lanelet2_map_visualizer): add new maker (#828) tier4/autoware_core#82

Merged

kotaro-hihara added a commit to tier4/autoware_core that referenced this pull request Mar 16, 2026

Merge pull request #82 from tier4/takagi/bv4312+area_filter

c47935a

feat(autoware_lanelet2_map_visualizer): add new maker (autowarefoundation#828)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(autoware_lanelet2_map_visualizer): add new maker#828

feat(autoware_lanelet2_map_visualizer): add new maker#828
yuki-takagi-66 merged 2 commits intoautowarefoundation:mainfrom
tier4:takagi/add-map_area_filter-maker

yuki-takagi-66 commented Feb 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

sasakisasaki left a comment

Uh oh!

codecov Bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

xmfcx commented Feb 20, 2026 •

edited

Loading

Uh oh!

xmfcx commented Feb 20, 2026

Uh oh!

mitsudome-r commented Feb 20, 2026

Uh oh!

xmfcx commented Feb 20, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

yuki-takagi-66 commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related links

How was this PR tested?

Notes for reviewers

Interface changes

Effects on system behavior

Uh oh!

github-actions Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sasakisasaki left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

xmfcx commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xmfcx commented Feb 20, 2026

Uh oh!

mitsudome-r commented Feb 20, 2026

Uh oh!

xmfcx commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yuki-takagi-66 commented Feb 3, 2026 •

edited

Loading

github-actions Bot commented Feb 3, 2026 •

edited

Loading

codecov Bot commented Feb 18, 2026 •

edited

Loading

xmfcx commented Feb 20, 2026 •

edited

Loading

xmfcx commented Feb 20, 2026 •

edited

Loading