Skip to content

Fix #6276: Type for timeout config options#6286

Open
pranavmanglik wants to merge 1 commit intoavocado-framework:masterfrom
pranavmanglik:master
Open

Fix #6276: Type for timeout config options#6286
pranavmanglik wants to merge 1 commit intoavocado-framework:masterfrom
pranavmanglik:master

Conversation

@pranavmanglik
Copy link

When setup_timeout or test_timeout are provided via a configuration
file, they are parsed as strings by default. This causes a TypeError
in aexpect when it attempts to calculate deadlines (float + str).

This explicitly sets key_type=int during option registration to
ensure proper casting.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical type mismatch issue where timeout configuration options, when loaded from a file, were being treated as strings instead of integers. By enforcing the correct integer type during option registration, the change prevents runtime errors in deadline calculations, ensuring the stability and reliability of timeout mechanisms within the system.

Highlights

  • Type Error Fix: Resolved a TypeError that occurred when setup_timeout or test_timeout were parsed as strings from configuration files, preventing proper deadline calculations.
  • Configuration Type Enforcement: Explicitly set key_type=int during the registration of setup_timeout and test_timeout options to ensure they are correctly cast to integers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mr-avocado mr-avocado bot moved this to Review Requested in Default project Mar 18, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds key_type=int to the setup_timeout and test_timeout option registrations in the remote spawner plugin. This is intended to ensure that when these values are loaded from a configuration file, they are cast to integers, fixing a TypeError. The change is correct and I have no further suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review Requested

Development

Successfully merging this pull request may close these issues.

1 participant