Skip to content

Small edits to Soak Tests #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anuraaga merged 1 commit into from
Sep 28, 2021
Merged

Small edits to Soak Tests #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions .github/scripts/performance-tests/produce_metric_widget_images.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,17 +366,22 @@ def parse_args():
f"Will create a snapshot at URL: https://github.com/{args.github_repository}/blob/gh-pages/{snapshot_location}",
)

# Delete oldest snapshots

snapshot_dirs_length = len(os.listdir(SOAK_TESTS_SNAPSHOTS_COMMITS_DIR))

if snapshot_dirs_length > args.max_benchmarks_to_keep:
oldest_snapshot_dirs = nsmallest(
snapshot_dirs_length - args.max_benchmarks_to_keep,
Path(SOAK_TESTS_SNAPSHOTS_COMMITS_DIR).iterdir(),
key=os.path.getmtime,
)
for old_snapshots_dir in oldest_snapshot_dirs:
shutil.rmtree(old_snapshots_dir, ignore_errors=True)
# Delete oldest run folders in most recent commit and oldest commit folders

for snapshots_dir in [
Copy link
Contributor

@anuraaga anuraaga Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split the change to auth and the other edits into separate PRs?

Copy link
Contributor Author

@NathanielRN NathanielRN Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, can do!

Copy link
Contributor Author

@NathanielRN NathanielRN Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved authentication updates to #88

SOAK_TESTS_SNAPSHOTS_COMMITS_DIR,
f"{SOAK_TESTS_SNAPSHOTS_COMMITS_DIR}/{ args.target_sha }/runs",
]:
snapshot_dirs_length = len(os.listdir(snapshots_dir))

if snapshot_dirs_length > args.max_benchmarks_to_keep:
oldest_snapshot_dirs = nsmallest(
snapshot_dirs_length - args.max_benchmarks_to_keep,
Path(snapshots_dir).iterdir(),
key=os.path.getmtime,
)
for old_snapshots_dir in oldest_snapshot_dirs:

shutil.rmtree(old_snapshots_dir, ignore_errors=True)

logger.info("Done creating metric widget images.")
6 changes: 3 additions & 3 deletions .github/workflows/soak-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ env:
AWS_WEB_IDENTITY_TOKEN_FILE: /tmp/awscreds
DEFAULT_TEST_DURATION_MINUTES: 300
HOSTMETRICS_INTERVAL_SECS: 600
CPU_LOAD_THRESHOLD: 71
TOTAL_MEMORY_THRESHOLD: 2147483648
CPU_LOAD_THRESHOLD: 40
TOTAL_MEMORY_THRESHOLD: 4294967296 # 4 GiB
MAX_BENCHMARKS_TO_KEEP: 100
# TODO: We might be able to adapt the "Soak Tests" to be "Overhead Tests".
# This means monitoring the Sample App's performance using high levels of TPS
Expand Down Expand Up @@ -238,7 +238,7 @@ jobs:
with:
filename: .github/auto-issue-templates/failure-during-soak_tests.md
- name: Publish Issue if failed AFTER Performance Tests
uses: NathanielRN/create-an-issue@v2.5.1-alpha2
uses: JasonEtco/create-an-issue@v2
if: ${{ github.event_name == 'schedule' &&
steps.check-failure-after-performance-tests.outcome == 'failure' }}
env:
Expand Down