feat(metrics): thread safety with concurrent collections and isolation for metrics#1080
Merged
feat(metrics): thread safety with concurrent collections and isolation for metrics#1080
Conversation
…orage. Add new TraceId capture from Lambda.Core to PowertoolsConfigurations.cs add new concurrency tests
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1080 +/- ##
===========================================
+ Coverage 78.21% 78.33% +0.12%
===========================================
Files 298 298
Lines 12045 12122 +77
Branches 1450 1456 +6
===========================================
+ Hits 9421 9496 +75
- Misses 2160 2161 +1
- Partials 464 465 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
leandrodamascena
approved these changes
Dec 16, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: #1079
Summary
Changes
This pull request introduces thread-safe handling for metrics contexts, enabling correct behavior when Lambda functions process multiple concurrent requests (e.g., when
AWS_LAMBDA_MAX_CONCURRENCY > 1). It also adds a new test project for concurrency testing and updates internal visibility accordingly.Thread safety and concurrency improvements:
MetricsinMetrics.csto use aConcurrentDictionaryfor per-thread metrics context storage. Shared configuration (namespace, service, default dimensions) is now kept in static fields, with thread-safe updates and propagation to all contexts. The singleton instance is now thread-safe, and all metrics operations (add, flush, set namespace/dimensions, etc.) operate on the current thread's context. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Other changes:
XRayTraceIdproperty inPowertoolsConfigurations.csto useLambdaTraceProvider.CurrentTraceIdfor improved trace ID retrieval.usingdirectives for required namespaces. [1] [2] [3]User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.