feat(logging): thread safety with ConcurrentDictionary for scope storage#1099
Merged
feat(logging): thread safety with ConcurrentDictionary for scope storage#1099
Conversation
…ope storage - Replace inner Dictionary with ConcurrentDictionary in _threadScopes to ensure thread-safe operations on scope values - Update Scope property return type from IDictionary to ConcurrentDictionary for consistency - Refactor SetKey method to use intermediate variable for better readability and null handling - Replace manual ContainsKey/Remove checks with TryRemove for atomic operations in RemoveKeys and RemoveKey methods - Update GetAllKeys to return a snapshot via ToArray() to prevent concurrent modification exceptions during enumeration - Add documentation clarifying that inner dictionary is ConcurrentDictionary and that GetAllKeys returns a snapshot for thread-safety - Improve code consistency by using ConcurrentDictionary methods throughout instead of mixing Dictionary and ConcurrentDictionary patterns
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1099 +/- ##
===========================================
- Coverage 78.55% 78.50% -0.06%
===========================================
Files 299 299
Lines 12376 12375 -1
Branches 1494 1492 -2
===========================================
- Hits 9722 9715 -7
- Misses 2180 2186 +6
Partials 474 474 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dreamorosi
approved these changes
Dec 18, 2025
leandrodamascena
approved these changes
Dec 18, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: #1076
Summary
Changes
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.