docs(batch_processing): snippets split, improved, and lint#2231
Conversation
boring-cyborg
Bot
added
the
documentation
pull-request-size
Bot
added
the
size/XXL
rubenfonseca
force-pushed
the
rf/refactor-batch
branch
from
afc9a59 to
3bbb1f2
Compare
|
1 similar comment
|
rubenfonseca
requested review from
leandrodamascena
and removed request for
a team
|
Hey @rubenfonseca! I'm starting the initial review and should have it wrapped up in the next 1-2 days. |
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
Hi @rubenfonseca! This is an incredible amount of work! I made some suggestions on things I found out.
btw, I pushed 2 commits with changes to correct things that I detected in the batch.md file.
rubenfonseca
changed the title
Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com> Signed-off-by: Ruben Fonseca <fonseka@gmail.com>
|
@leandrodamascena ready for round 2 |
There was a problem hiding this comment.
Oh mypy!!! WHY?? 😢
I'll move this to the parent folder.
poetry run mypy --pretty aws_lambda_powertools examples
examples/parameters/tests/src/__init__.py: error: Duplicate module named "src" (also at "examples/batch_processing/testing/src/__init__.py")
examples/parameters/tests/src/__init__.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
examples/parameters/tests/src/__init__.py: note: Common resolutions include: a) using `--exclude` to avoid checking one of them, b) adding `__init__.py` somewhere, c) using `--explicit-package-bases` or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #2231 +/- ##
========================================
Coverage 97.46% 97.46%
========================================
Files 149 149
Lines 6895 6895
Branches 506 506
========================================
Hits 6720 6720
Misses 137 137
Partials 38 38 ☔ View full report in Codecov by Sentry. |
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
Hi @rubenfonseca! Since you are at the Summit this week and I don't want to bother you with minor changes, I pushed 1 commit with some changes.
Please check if it makes sense, if it does, for me this PR is approved!! One more GREAT job man!
|
@leandrodamascena changes look good! I've made a quick fix to one of the highlights, and for me it's good to merge :) |
leandrodamascena
changed the title
* develop: chore(ci): bump package version after release via pull request (aws-powertools#2239) chore(ci): convert create-pr steps into composite action (aws-powertools#2238) chore(ci): changelog rebuild (aws-powertools#2241) chore(deps-dev): bump aws-cdk from 2.78.0 to 2.79.0 (aws-powertools#2235) docs(batch_processing): snippets split, improved, and lint (aws-powertools#2231) chore(deps-dev): bump mypy from 1.2.0 to 1.3.0 (aws-powertools#2233)
3 participants
Issue number: #1369
Summary
Changes
This PR extracts, fixes and refactors all code snippets for the batch utility.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.