fix(core): import time latency by lazily loading high level modules#301
Merged
heitorlessa merged 17 commits intoMar 3, 2021
Merged
Conversation
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Contributor
|
@heitorlessa nice, definitely handy for lambdas that just want structured logging or want to toggle tracing only for dev and test and disable on production. |
Contributor
Author
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Contributor
Author
|
Done - @nmoutschen, do you have the bandwidth to review? |
nmoutschen
reviewed
Mar 3, 2021
Contributor
nmoutschen
left a comment
There was a problem hiding this comment.
I have a few questions/remarks before I can approve. We also need to include the proper licensing for the class taken from Terraform (Apache-2.0 license).
Codecov Report
@@ Coverage Diff @@
## develop #301 +/- ##
===========================================
- Coverage 99.71% 99.65% -0.06%
===========================================
Files 87 90 +3
Lines 3150 3206 +56
Branches 149 150 +1
===========================================
+ Hits 3141 3195 +54
- Misses 5 7 +2
Partials 4 4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Issue #, if available: #294
Description of changes:
Checklist
aws_xray_sdkaws_xray_sdk.corefastjsonschemaChanges table
Notes
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.