docs(metrics): Correct code examples in markdown#316
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #316 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 91 91
Lines 3339 3341 +2
Branches 162 163 +1
========================================
+ Hits 3335 3337 +2
Misses 2 2
Partials 2 2
Continue to review full report at Codecov.
|
Contributor
Author
|
Sorry one more @heitorlessa . I am picking them up as i try to copy and paste from the docs. |
heitorlessa
added
documentation
heitorlessa
approved these changes
Mar 7, 2021
Contributor
heitorlessa
left a comment
heitorlessa
left a comment
There was a problem hiding this comment.
Thanks ;) I had left no MetricUnit to make it easier for people coming from bare SDK or EMF library.
But makes sense to keep using our enum as that's a good feature
Contributor
Author
|
@heitorlessa cool, which ever code examples you would prefer people to copy from. |
heitorlessa
added a commit
that referenced
this pull request
Mar 9, 2021
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: feat(logging): Include exception_name (#320) chore: remove gatsby mention as migrated completed refactor(parameters): Consistently reference env (#319) docs(metrics): remove minimum dimensions docs: Correct code examples (#317) docs(metrics): Correct code examples in markdown (#316) fix(idempotency): TypeError when calling is_missing_idempotency_key with an int (#315) docs(metrics): Corrections to the code examples (#314) fix(idempotency): Correctly handle save_inprogress errors (#313)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Correct the metrics code examples to use
MetricUnit.Countwhen it was imported otherwiseremove when not used in code sample
Checklist