docs(tracer): Fix Tracer typing hinting for Pycharm#345
Merged
Conversation
Contributor
Author
|
@heitorlessa this seems to fix the issue with PyCharm and Tracer |
heitorlessa
suggested changes
Mar 17, 2021
Contributor
heitorlessa
left a comment
heitorlessa
left a comment
There was a problem hiding this comment.
tiny change and it should be good to release!
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Typing for Tracer seems to be broken on PyCharm, see screenshot below:
The location of the
Returnsdoc string is causing the PyCharm linter to thing thatTraceris a tuple (possibly also due to the_default_configand_configbefore the__init__?Description of changes:
Changes:
Returnsto just below theParametersproviderproviderChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.