feat(idempotency): add idempotency decorator - #1723
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
Contributor
Author
dreamorosi
approved these changes
Sep 28, 2023
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Great work on this PR, Alex!
I've left a few comments on the docs only. The general feedback would be to: 1/ let's try to start using import type { fooBar } from '...'; when importing types. This helps with telling TS what we are importing.
Contributor
|
Thanks for running the integration tests, they are passing 🎉 |
dreamorosi
added a commit
that referenced
this pull request
Sep 28, 2023
This reverts commit d138673.
9 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds
@idempotentdecorator to the utility. We initially implemented it, but removed later due to uncertainty about decorator interface with TypeScript 5.x upgrade. Now we can restore and simplify the old implementation, by internally callingmakeIdempotent, making it syntactic sugar for this functionality. This also means that most of e2e tests are very similar to themakeIdempotenttests, but we still need to make sure that it works when wrapping around decorator.Related issues, RFCs
Issue number: closes #1700
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.