chore(examples): integrate in CI flow with lint and build#446
Merged
Conversation
dreamorosi
previously approved these changes
Jan 10, 2022
Contributor
dreamorosi
left a comment
There was a problem hiding this comment.
Only a couple of minor suggestions on the CONTRIBUTING.md file, otherwise lgtm.
dreamorosi
previously approved these changes
Jan 10, 2022
385b27a to
df65b1f
Compare
dreamorosi
reviewed
Jan 17, 2022
dreamorosi
reviewed
Jan 17, 2022
dreamorosi
reviewed
Jan 17, 2022
dreamorosi
previously approved these changes
Jan 17, 2022
dreamorosi
approved these changes
Jan 17, 2022
saragerion
reviewed
Jan 17, 2022
ijemmy
suggested changes
Jan 18, 2022
Contributor
ijemmy
left a comment
There was a problem hiding this comment.
Could you double check the npm install .. . I think it only installs commons package.
ijemmy
approved these changes
Jan 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
(built on top of #439)
Examples were not linted or built leading to missed bugs and compilation errors.
This PR homoganize the structure of cdk examples as well as make them lint and built the same way as modules.
It also add a job in e2e test workflow to test compilation of future published packages and avoid this kind of needed fix #470
How to verify this change
Related issues, RFCs
To catch #435
Built on top of #439
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.