feat(examples): added sam example to workflows#849
Merged
Conversation
flochaz
previously approved these changes
May 11, 2022
saragerion
approved these changes
May 11, 2022
flochaz
approved these changes
May 12, 2022
This was referenced May 12, 2022
dreamorosi
added a commit
that referenced
this pull request
Aug 2, 2022
* feat: added sam example to workflows * chore: added package-lock * Modified symlink * Fix import * Added jest to sam * Added jest to sam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
In a recent PR (#674) we received a contribution that added SAM examples to the repo. This PR aims at incorporating these examples into the CI/CD workflows we have at the moment. This includes linting of the sources, as well as building (
sam build), and extremely basic unit tests that ensure that the functions can be imported & called.List of changes:
examples/sam/src/handlerstoexamples/sam/src, to conform to the structure needed by the linting commands (updatedREADME&template.yml, no effect on the actual sample).tsconfig,jest.config,package-lock, etc.).scriptsstanza to thepackage.jsonto support various commands.examples/cdkfolder that I came across while copying parts of the code.How to verify this change
Check the execution result of the GitHub actions included in this PR.
Related issues, RFCs
#674
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.