feat(all): nodejs16x support#877
Merged
Merged
Conversation
flochaz
suggested changes
May 18, 2022
Co-authored-by: Florian Chazal <florianchazal@gmail.com>
flochaz
previously approved these changes
May 18, 2022
ijemmy
previously approved these changes
May 23, 2022
Contributor
ijemmy
left a comment
ijemmy
left a comment
There was a problem hiding this comment.
This is very thorough. It's scary on how much duplication we have.
(esp. on my E2E code. Should have made the default version a constant.)
| working-directory: ./examples/sam | ||
| run: npm ci | ||
| run: | | ||
| sam --version |
Contributor
There was a problem hiding this comment.
(nit) Is this intentional or just for debug?
Contributor
Author
There was a problem hiding this comment.
Good catch, I need to remove this
8 tasks
ijemmy
approved these changes
May 24, 2022
flochaz
approved these changes
May 24, 2022
flochaz
added a commit
that referenced
this pull request
Jun 3, 2022
* feat: added node16 to e2e test * Added runtime to e2eUtils * feat: added node16 to e2e test * chore: added runtime key * chore: update occurrences of nodejs14x * test sam version * test sam version * revert * sam * sam * sam * sam * chore: added .nvmrc * chore: updated cdk example runtime * Update packages/metrics/tests/e2e/basicFeatures.decorators.test.ts Co-authored-by: Florian Chazal <florianchazal@gmail.com> Co-authored-by: Florian Chazal <florianchazal@gmail.com>
dreamorosi
added a commit
that referenced
this pull request
Aug 2, 2022
* feat: added node16 to e2e test * Added runtime to e2eUtils * feat: added node16 to e2e test * chore: added runtime key * chore: update occurrences of nodejs14x * test sam version * test sam version * revert * sam * sam * sam * sam * chore: added .nvmrc * chore: updated cdk example runtime * Update packages/metrics/tests/e2e/basicFeatures.decorators.test.ts Co-authored-by: Florian Chazal <florianchazal@gmail.com> Co-authored-by: Florian Chazal <florianchazal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
AWS Lambda announced support for Node JS 16 a few days ago, this PR aims at adding support to that same runtime.
The changes in the PR revolve around:
nodejs16xruntime to the e2e test matrixHow to verify this change
See successful run for GitHub Actions under this PR, as well as a successful run for the e2e tests that now includes the new runtime as part of the matrix (link to execution).
Related issues, RFCs
#830
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.