chore(examples): cleanup old examples#903
Merged
Merged
Conversation
github-actions
Bot
added
the
internal
flochaz
approved these changes
May 30, 2022
ijemmy
approved these changes
Jun 1, 2022
Contributor
ijemmy
left a comment
ijemmy
left a comment
There was a problem hiding this comment.
Not sure if the change on Lambda interface is intentional.
Apart from that, I'm good with this change.
Comment on lines
+15
to
+21
| import { Context, Handler } from 'aws-lambda'; | ||
| import { Console } from 'console'; | ||
|
|
||
| interface LambdaInterface { | ||
| handler: Handler | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Why do we add this interface?
Contributor
Author
There was a problem hiding this comment.
It's needed for the decorator unit test cases, Tracer has one like this as well.
Before this PR it used to be in a separate file inside the now deleted folder. I have added it to this file instead of living a folder with one single file of 3 lines.
dreamorosi
added a commit
that referenced
this pull request
Aug 2, 2022
* chore: cleaned up examples + removed links * chore: remove leftovers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR aims at removing unused and obsolete examples that were initially created in the very early stages of the project and that later went unmaintained. Now that the repo has two examples in CDK and SAM under the
examplesfolder, the ones that were under of thepackages/loggerandpackages/metricsfolders can be removed.The diff for this PR is big as each example had its own file. Aside from the files removed the changes include:
pacakges/[logger|metrics]/package.jsonfiles to remove the npm scripts to run these examplesWhen merged this issue will close #332
How to verify this change
See existing unit tests pass successfully on GitHub actions.
Related issues, RFCs
#332
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.