docs: ADR-002 least-privilege CDK bootstrap policies#133
Conversation
0174e2a to
010786e
Compare
Without force-push after rebase, GitHub shows already-merged commits in child PRs — reviewers cannot distinguish new work from old. Make the retarget→rebase→force-push sequence explicit and mandatory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
The ADR template defines Status, Date, Supersedes, and Superseded-by as header metadata. Move the ADR-001 cross-reference from the non-standard header field to the ## References section for template conformance. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Nice ADR — the existing-artifact claims (PR #46, DEPLOYMENT_ROLES.md, the "7 iterations / 36 CloudTrail actions" provenance, the three policy names) all check out verbatim against the current docs, and the Starlight mirrors regenerate cleanly. One ask before merge: a few artifacts in the Decision section are written in present indicative even though they don't exist yet on
Two options for fixing — either works: Option A (lightest touch): add one line under Status like:
Option B (clearer per-item): tag each forward-looking artifact with
Also a small process question on the ADR-001 amendment ( Non-blocking nit: in References, |
Address review feedback: distinguish shipped state from design intent. Add Implementation line noting progressive delivery, tag each artifact with its landing issue number, use future tense for unbuilt components. ADR-001 reference now a relative link for Starlight clickability. Note on ADR-001 amendment (§8 merge semantics): this is a clarification of existing intent (retarget/rebase protocol), not a reversal of the original decision — treated as additive refinement per README lifecycle. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Addressed in Option A + B combined:
ADR-001 amendment note: Covered in the commit message — this is a clarification of existing intent (the retarget/rebase protocol that was already implied by "early PRs can merge and ship"), not a reversal. Treated as additive refinement per the README lifecycle ("to change an accepted decision, write a new ADR" applies to reversals, not clarifications). Nit fixed: ADR-001 reference is now a relative link |
Stack position
PR 2 of 4 for #145 — Least-privilege CDK bootstrap policies as code
Prior (PR 1 / #130): ADR framework + ADR-001 stacked pull requests methodology
This PR: ADR-002 recording the design decisions for the bootstrap policies work
Remaining (7 PRs): policies as TypeScript, bootstrap template, resource-action-map, CDK Aspect, preflight validator, CI integration, documentation updates
Summary
Records the "why" behind all major design choices from RFC #120:
cdk/src/bootstrap/(agent routing, testability, co-location)Changes
docs/decisions/002-least-privilege-bootstrap-policies.mddocs/src/content/docs/decisions/002-least-privilege-bootstrap-policies.mdTest plan
astro check— 0 errorsCloses #121
🤖 Generated with Claude Code