ci: add Slack PR review notification caller - #1947
Merged
Merged
Conversation
Pings reviewers in Slack via the shared reusable workflow (pinned @69340df): - review requested -> ping the reviewer - review submitted -> ping the author - new revision -> ping prior reviewers/commenters
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-1947-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.26.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
aidandaly24
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the caller workflow that pings PR reviewers in Slack (#agentcore-sdk-cli-prs) via the shared reusable
reusable-slack-pr-review-notification(pinned@69340df).Behavior
Mentions render as real Slack pills (Person-type vars, IDs resolved from the
SLACK_PR_REVIEW_USER_MAPsecret). Verified end-to-end against the live Slack workflow.Depends on
SLACK_PR_REVIEW_WEBHOOK_URL+SLACK_PR_REVIEW_USER_MAP(created) and reader-role grants (done for all 6 repos).