Skip to content
This repository was archived by the owner on Nov 19, 2025. It is now read-only.

Update docker/cli, add src override for docker/docker#658

Merged
allisaurus merged 1 commit into
aws:devfrom
allisaurus:update-docker
Oct 30, 2018
Merged

Update docker/cli, add src override for docker/docker#658
allisaurus merged 1 commit into
aws:devfrom
allisaurus:update-docker

Conversation

@allisaurus
Copy link
Copy Markdown
Contributor

Testing

Success (var exists)

docker-compose.yml:

version: '3'
services:
  wordpress:
    image: httpd
    ports:
      - "80:80"
    environment:
     - "OS: ${OS}"
     - "username: ${USERNAME:?err}"  # existing env var

output (success) :

$~> ..\..\Documents\GO\src\github.com\aws\amazon-ecs-cli\bin\local\ecs-cli.exe compose up
INFO[0000] Using ECS task definition                     TaskDefinition="651:4"
INFO[0000] Found existing ECS tasks for project          CountOfTasks=1 ProjectName=651
INFO[0000] Updating to new task definition               taskDefinition="arn:aws:ecs:us-west-2:##########:task-definition/651:4"
INFO[0000] Describe ECS container status                 container=45f966e6-1de4-41ae-9443-c62fea0ff108/wordpress desiredStatus=STOPPED lastStatus=RUNNING taskDefinition="651:3"
INFO[0000] Describe ECS container status                 container=0d60d854-0d90-48e7-bff0-31a6b8eff6f0/wordpress desiredStatus=RUNNING lastStatus=PENDING taskDefinition="651:4"
INFO[0006] Stopped container...                          container=45f966e6-1de4-41ae-9443-c62fea0ff108/wordpress desiredStatus=STOPPED lastStatus=STOPPED taskDefinition="651:3"
INFO[0012] Started container...                          container=0d60d854-0d90-48e7-bff0-31a6b8eff6f0/wordpress desiredStatus=RUNNING lastStatus=RUNNING taskDefinition="651:4"

Missing var (error)

docker-compose.yml:

version: '3'
services:
  wordpress:
    image: httpd
    ports:
      - "80:80"
    environment:
     - "OS: ${OS}"
     - "username: ${MISSING:?err}"  # non-existent env var

output (error):

$~> ..\..\Documents\GO\src\github.com\aws\amazon-ecs-cli\bin\local\ecs-cli.exe compose up
ERRO[0000] Unable to open ECS Compose Project            error="invalid interpolation format for services.wordpress.environment.[]: \"required variable MISSING is missing a value: err\". You may need to escape any $ with another $."
FATA[0000] Unable to create and read ECS Compose Project  error="invalid interpolation format for services.wordpress.environment.[]: \"required variable MISSING is missing a value: err\". You may need to escape any $ with another $."

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

}

// load config from config details

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes grood seems load-bearing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X(

Comment thread ecs-cli/Gopkg.toml Outdated
[[constraint]]
name = "github.com/docker/cli"
revision = "1872bd802c697f39eb783a9b7d25e60d6fe601d6"
revision = "750b038707852caa10806d6f760dffbe09f9c5c1"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we can't track something less binding than a revision? (e.g. version)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants