Skip to content

feat: CDK LSP/Explorer Package Scaffolding - #1559

Merged
megha-narayanan merged 2 commits into
aws:feat/cdk-lsp-explorerfrom
megha-narayanan:feat/explorer-process-architecture
May 27, 2026
Merged

feat: CDK LSP/Explorer Package Scaffolding#1559
megha-narayanan merged 2 commits into
aws:feat/cdk-lsp-explorerfrom
megha-narayanan:feat/explorer-process-architecture

Conversation

@megha-narayanan

Copy link
Copy Markdown
Contributor

Basic scaffolding for new packages to be implemented: a core functionality library, the lsp server, and the web explorer.

Checklist

  • This change contains a major version upgrade for a dependency and I confirm all breaking changes are addressed
    • Release notes for the new version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
aws-cdk-automation requested a review from a team May 27, 2026 17:55
@github-actions github-actions Bot added the p2 label May 27, 2026
@megha-narayanan megha-narayanan changed the title CDK LSP/Explorer Package Scaffolding feat: CDK LSP/Explorer Package Scaffolding May 27, 2026

@ShadowCat567 ShadowCat567 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: Why not have one package that holds all the architecture for the LSP and the Web Explorer and having sub directories within that package?
The toolkit-lib package kind of does this pattern

@megha-narayanan
megha-narayanan force-pushed the feat/explorer-process-architecture branch from 55cafe0 to 25c9b67 Compare May 27, 2026 18:45

@ShadowCat567 ShadowCat567 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for initial scaffolding

@megha-narayanan
megha-narayanan merged commit 854762b into aws:feat/cdk-lsp-explorer May 27, 2026
38 checks passed
fossamagna pushed a commit to fossamagna/aws-cdk-cli that referenced this pull request Jul 17, 2026
Merges the`feat/cdk-lsp' branch into `main`. The change is additive and
introduces no behavior change to existing CLI commands.

- New `@aws-cdk/cdk-explorer` package containing the Language Server
under `lib/lsp` (server, diagnostics, CodeLens, template locator,
position mapping).
- Extends `@aws-cdk/cloud-assembly-api` with two parsing modules
consumed by the server: `construct-tree.ts` (builds the construct tree
from a cloud assembly) and `template-ranges.ts` (resolves a logical ID
or property to its byte range in the template).

Capabilities (folds in aws#1559, aws#1593, aws#1592, aws#1617, aws#1624, aws#1630, aws#1631,
aws#1662, aws#1634, aws#1674):

- Diagnostics: surfaces synth errors and policy-validation violations in
the editor, mapped back to the source.
- Surfaces CFN resources and adds CodeLens navigation from a construct
to its template resource.
- Navigation between construct source and the synthesized template in
both directions.
- Live refresh: diagnostics and CodeLens update when `cdk.out` changes.
- Reads are constrained to the project directory, and template reads run
off the LSP event loop.

This PR is the server and parsing foundation. It does not add a shipped
CLI command or the web explorer.

### Checklist
- [ ] This change contains a major version upgrade for a dependency and
I confirm all breaking changes are addressed
  - Release notes for the new version:

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Otavio Macedo <288203+otaviomacedo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants