chore: modernize tsconfig settings across all packages

.projenrc.ts

@@ -125,11 +125,12 @@ const ADDITIONAL_CLI_IGNORE_PATTERNS = [
 ];
 
 const defaultTsOptions: NonNullable<TypeScriptWorkspaceOptions['tsconfig']>['compilerOptions'] = {
-  target: 'ES2020',
-  module: 'commonjs',
-  lib: ['es2020'],
+  module: 'node18',
+  target: 'es2022',
+  lib: ['es2022'],
   incremental: true,
-  esModuleInterop: false,
+  esModuleInterop: true,
+  noEmitOnError: true,
   skipLibCheck: true,
   isolatedModules: true,
 };
@@ -544,14 +545,6 @@ const cloudFormationDiff = configureProject(
       'string-width@^4',
       'table@^6',
     ],
-    // FIXME: this should be a jsii project
-    // (EDIT: or should it? We're going to bundle it into aws-cdk-lib)
-    tsconfig: {
-      compilerOptions: {
-        ...defaultTsOptions,
-      },
-    },
-
     jestOptions: jestOptionsForProject({
       jestConfig: {
         coverageThreshold: {
@@ -630,11 +623,6 @@ const yarnCling = configureProject(
     deps: ['@yarnpkg/parsers', 'semver'],
     devDeps: ['@types/semver', 'fast-check'],
     minNodeVersion: '20',
-    tsconfig: {
-      compilerOptions: {
-        ...defaultTsOptions,
-      },
-    },
     jestOptions: jestOptionsForProject({
       jestConfig: {
         coverageThreshold: {
@@ -663,11 +651,6 @@ const yargsGen = configureProject(
     deps: ['@cdklabs/typewriter', 'prettier@^2.8', 'lodash.clonedeep'],
     devDeps: ['@types/semver', '@types/yarnpkg__lockfile', '@types/lodash.clonedeep', '@types/prettier@^2'],
     minNodeVersion: '20', // Necessary for 'structuredClone'
-    tsconfig: {
-      compilerOptions: {
-        ...defaultTsOptions,
-      },
-    },
   }),
 );
 
@@ -688,11 +671,6 @@ const cliPluginContract = configureProject(
     ],
     devDeps: [
     ],
-    tsconfig: {
-      compilerOptions: {
-        ...defaultTsOptions,
-      },
-    },
   }),
 );
 
@@ -760,20 +738,6 @@ const cdkAssetsLib = configureProject(
       'aws-sdk-client-mock',
       'aws-sdk-client-mock-jest',
     ],
-    tsconfigDev: {
-      compilerOptions: {
-        ...defaultTsOptions,
-      },
-      include: ['bin/**/*.ts'],
-    },
-    tsconfig: {
-      compilerOptions: {
-        ...defaultTsOptions,
-        rootDir: undefined,
-        outDir: undefined,
-      },
-      include: ['bin/**/*.ts'],
-    },
     jestOptions: jestOptionsForProject({
       jestConfig: {
         // We have many tests here that commonly time out
@@ -897,9 +861,7 @@ const TOOLKIT_LIB_EXCLUDE_PATTERNS = [
 
 const toolkitLibTsCompilerOptions = {
   ...defaultTsOptions,
-  target: 'es2022',
   lib: ['es2022', 'esnext.disposable'],
-  module: 'NodeNext',
   declarationMap: true,
 };
 
@@ -1011,12 +973,6 @@ const toolkitLib = configureProject(
         ...toolkitLibTsCompilerOptions,
       },
     },
-    tsconfigDev: {
-      compilerOptions: {
-        ...toolkitLibTsCompilerOptions,
-        rootDir: '.', // shouldn't be required but something broke... check again once we have gotten rid of the tmpToolkitHelpers package
-      },
-    },
     nextVersionCommand: 'tsx ../../../projenrc/next-version.ts maybeRc',
   }),
 );
@@ -1303,25 +1259,10 @@ const cli = configureProject(
       'yargs@^15',
     ],
     excludeDepsFromUpgrade: ['aws-cdk-lib'], // this is handled separately further down
-    tsconfig: {
-      compilerOptions: {
-        ...defaultTsOptions,
-        lib: ['es2019', 'es2022.error'],
-
-        // Changes the meaning of 'import' for libraries whose top-level export is a function
-        // 'aws-cdk' has been written against `false` for interop
-        esModuleInterop: false,
-
-        // Necessary to properly compile proxy-agent and lru-cache without esModuleInterop set.
-        skipLibCheck: true,
-      },
-    },
     tsconfigDev: {
       compilerOptions: {
         ...defaultTsOptions,
-        lib: ['es2019', 'esnext.disposable', 'es2022.error'],
-        esModuleInterop: false,
-        skipLibCheck: true,
+        lib: ['es2022', 'esnext.disposable'],
       },
     },
     eslintOptions: {
@@ -1471,11 +1412,6 @@ const cdkAliasPackage = configureProject(
     nextVersionCommand: `tsx ../../projenrc/next-version.ts copyVersion:../../${cliPackageJson}`,
     releasableCommits: transitiveToolkitPackages('cdk'),
     majorVersion: 2,
-    tsconfig: {
-      compilerOptions: {
-        ...defaultTsOptions,
-      },
-    },
   }),
 );
 void cdkAliasPackage;
@@ -1657,10 +1593,8 @@ const cliInteg = configureProject(
     tsconfig: {
       compilerOptions: {
         ...defaultTsOptions,
-        esModuleInterop: false,
         target: 'es2022',
         lib: ['es2022', 'esnext.disposable', 'dom'],
-        module: 'NodeNext',
       },
       include: ['**/*.ts'],
       exclude: ['resources/**/*'],

packages/@aws-cdk-testing/cli-integ/lib/with-cdk-app.ts

@@ -1,5 +1,5 @@
 /* eslint-disable no-console */
-import * as assert from 'assert';
+import assert from 'assert';
 import * as fs from 'fs';
 import * as os from 'os';
 import * as path from 'path';

packages/@aws-cdk/cdk-assets-lib/test/docker-images.test.ts

@@ -2,7 +2,7 @@ jest.mock('child_process');
 
 import 'aws-sdk-client-mock-jest';
 
-import * as fs from 'fs';
+import fs from 'fs';
 import { Manifest } from '@aws-cdk/cloud-assembly-schema';
 import type { GetAuthorizationTokenResponse } from '@aws-sdk/client-ecr';
 import {

packages/@aws-cdk/cdk-build-tools/lib/os.ts

@@ -1,7 +1,7 @@
 import * as child_process from 'child_process';
 import * as fs from 'fs';
 import * as util from 'util';
-import * as chalk from 'chalk';
+import chalk from 'chalk';
 import { Timers } from './timer';
 
 interface ShellOptions {