chore: extract assembly read-lock factory into core - #1715
Merged
megha-narayanan merged 2 commits intoJul 8, 2026
Merged
Conversation
Move the AssemblyLock type and the fromAssemblyDirectory().produce()-backed acquirer out of lib/lsp into lib/core/assembly-lock.ts, so both the LSP and the web server can build the read lock from one shared factory. Pure refactor: LSP behavior is unchanged and server.ts re-exports AssemblyLock for existing importers.
megha-narayanan
temporarily deployed
to
automation
July 8, 2026 16:12 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
megha-narayanan
had a problem deploying
to
integ-approval
July 8, 2026 16:12 — with
GitHub Actions
Failure
GitHub Actions
Failure
megha-narayanan
marked this pull request as ready for review
July 8, 2026 16:12
megha-narayanan
changed the title
megha-narayanan
changed the title
ShadowCat567
reviewed
Jul 8, 2026
| release(): Promise<void>; | ||
| } | ||
| // Re-exported from core so existing importers keep resolving `AssemblyLock` here. | ||
| export type { AssemblyLock }; |
Contributor
There was a problem hiding this comment.
This looks a little weird to me, why can't we update the import in other places to point towards core?
Contributor
Author
There was a problem hiding this comment.
yes oops this is just for the test, fixed
…-export The type lives in lib/core/assembly-lock now. Point the only remaining importer (the server test) at core directly and remove the compatibility re-export from lsp/server.ts so core is the single source for the type.
megha-narayanan
had a problem deploying
to
integ-approval
July 8, 2026 18:13 — with
GitHub Actions
Failure
GitHub Actions
Failure
ShadowCat567
approved these changes
Jul 8, 2026
megha-narayanan
added a commit
to megha-narayanan/aws-cdk-cli
that referenced
this pull request
Jul 8, 2026
…and template Rebased aws#1706 onto the updated feat/cdk-explorer (now carrying feat/cdk-lsp) as a single integration commit. Adds source/template/tree navigation with syntax highlighting, a YAML template view, and a file picker, and serves each assembly read under the Toolkit read lock via the factory core extracted in aws#1715. Coexists with the SSE live-refresh from aws#1698: the reload effect and the navigation state share the same App shell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching LSP side of #1706. Moves the assembly read-lock acquirer out of
lib/lsp into lib/core/assembly-lock.ts so the LSP and web server build the
read lock from one shared factory. Pure refactor, LSP behavior is unchanged,
and server.ts re-exports AssemblyLock so existing importers keep resolving it.
Fixes #
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license