fix(cli): hotswap properly uses cached template diff when hotswap template is same as current CloudFormation template - #1819
Open
ShadowCat567 wants to merge 4 commits into
Open
fix(cli): hotswap properly uses cached template diff when hotswap template is same as current CloudFormation template #1819ShadowCat567 wants to merge 4 commits into
ShadowCat567 wants to merge 4 commits into
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making multiple hotswap deployments in a row, hotswap should compare between the template currently being deployed and the last hotswap template. This happens properly most of the time, however when a change is made that would cause the template being hotswapped to be the same as the template in CloudFormation,
canSkipDeploywas not checking the cached hotswap template and did not register that a change could be deployed via hotswap.Updates the behavior of
canSkipDeployso it checks the hotswap cache if we are deploying with hotswap and does not skip the hotswap deployment if the cached hotswap template and the template currently being deployed differ.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license