feat(cli): change set review on deploy - #892
Closed
orien wants to merge 1 commit into
Closed
Conversation
orien
had a problem deploying
to
integ-approval
September 24, 2025 12:39 — with
GitHub Actions
Failure
orien
commented
Sep 24, 2025
| const execute = deploymentMethod.execute ?? true; | ||
| const importExistingResources = deploymentMethod.importExistingResources ?? false; | ||
| const changeSetDescription = await this.createChangeSet(changeSetName, execute, importExistingResources); | ||
| const executeExistingChangeSet = deploymentMethod.executeExistingChangeSet ?? false; |
Contributor
Author
There was a problem hiding this comment.
Support deploying/executing an existing CloudFormation change set.
orien
force-pushed
the
0370-change-set-approval
branch
from
September 25, 2025 06:11
97b1243 to
25acc82
Compare
orien
had a problem deploying
to
integ-approval
September 25, 2025 06:11 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
September 25, 2025 06:16
25acc82 to
09163dd
Compare
orien
had a problem deploying
to
integ-approval
September 25, 2025 06:17 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
September 25, 2025 12:54
09163dd to
b2bae60
Compare
orien
had a problem deploying
to
integ-approval
September 25, 2025 12:54 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
September 25, 2025 15:02
b2bae60 to
ef4cdd3
Compare
orien
had a problem deploying
to
integ-approval
September 25, 2025 15:02 — with
GitHub Actions
Failure
orien
marked this pull request as ready for review
September 25, 2025 15:04
orien
force-pushed
the
0370-change-set-approval
branch
from
September 25, 2025 17:43
ef4cdd3 to
7920c88
Compare
orien
had a problem deploying
to
integ-approval
September 25, 2025 17:43 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
September 30, 2025 08:06
7920c88 to
5844733
Compare
orien
had a problem deploying
to
integ-approval
September 30, 2025 08:06 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
September 30, 2025 08:49
5844733 to
91a2f71
Compare
orien
had a problem deploying
to
integ-approval
September 30, 2025 08:49 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
September 30, 2025 09:40
91a2f71 to
c1e9805
Compare
orien
had a problem deploying
to
integ-approval
September 30, 2025 09:40 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
October 1, 2025 03:33
c1e9805 to
797befd
Compare
orien
force-pushed
the
0370-change-set-approval
branch
from
October 2, 2025 01:55
797befd to
a4bedea
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 87.70% 87.93% +0.22%
==========================================
Files 72 72
Lines 10121 10203 +82
Branches 1337 1352 +15
==========================================
+ Hits 8877 8972 +95
+ Misses 1219 1206 -13
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orien
force-pushed
the
0370-change-set-approval
branch
from
October 7, 2025 08:27
a4bedea to
bdc029f
Compare
orien
force-pushed
the
0370-change-set-approval
branch
from
October 7, 2025 09:05
bdc029f to
fbfa223
Compare
orien
force-pushed
the
0370-change-set-approval
branch
from
October 12, 2025 05:43
8e8d4c1 to
5ca2053
Compare
orien
had a problem deploying
to
integ-approval
October 12, 2025 05:43 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
October 26, 2025 10:25
5ca2053 to
562c273
Compare
orien
had a problem deploying
to
integ-approval
October 26, 2025 10:25 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
November 23, 2025 03:38
562c273 to
274be5e
Compare
orien
had a problem deploying
to
integ-approval
November 23, 2025 03:39 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
December 28, 2025 04:08
274be5e to
7704aa0
Compare
orien
had a problem deploying
to
integ-approval
December 28, 2025 04:08 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
January 4, 2026 09:53
7704aa0 to
f297641
Compare
orien
force-pushed
the
0370-change-set-approval
branch
from
January 7, 2026 11:44
f297641 to
71ddd41
Compare
orien
force-pushed
the
0370-change-set-approval
branch
from
January 16, 2026 14:34
71ddd41 to
02c4bae
Compare
orien
had a problem deploying
to
integ-approval
January 16, 2026 14:34 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
January 25, 2026 08:59
02c4bae to
4dd1262
Compare
orien
had a problem deploying
to
integ-approval
January 25, 2026 08:59 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
February 25, 2026 10:35
4dd1262 to
21c3271
Compare
orien
had a problem deploying
to
integ-approval
February 25, 2026 10:35 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
February 25, 2026 12:07
21c3271 to
5483639
Compare
orien
had a problem deploying
to
integ-approval
February 25, 2026 12:07 — with
GitHub Actions
Failure
aws-cdk-automation
had a problem deploying
to
integ-approval
February 25, 2026 12:21 — with
GitHub Actions
Failure
orien
force-pushed
the
0370-change-set-approval
branch
from
February 25, 2026 12:29
dd56c55 to
ac6deb7
Compare
orien
had a problem deploying
to
integ-approval
February 25, 2026 12:29 — with
GitHub Actions
Failure
Contributor
Contributor
|
Superseded by
|
Contributor
|
Thank you for your feedback @orien and the contribution of the initial POC for this! |
Contributor
Author
|
Thanks @mrgrain. I haven't had time to pursue this idea further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #801 and RFC 370: CLI deploy with change set review confirmation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license