Added support for aws s3 presign for HTTP PUT request. And added Examples for aws s3 presign#3979
Added support for aws s3 presign for HTTP PUT request. And added Examples for aws s3 presign#3979max6746 wants to merge 3 commits intoaws:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3979 +/- ##
========================================
Coverage 94.41% 94.41%
========================================
Files 188 188
Lines 14234 14234
========================================
Hits 13439 13439
Misses 795 795
Continue to review full report at Codecov.
|
|
@jamesls May you have a look and feedback over this will be helpful. |
|
I was looking for something just like this earlier! I hope it ends up being merged :-) |
|
Before seeing this I started making the same change. I hope this gets added, it would come in very handy to be able to generate pre-signed upload URLs for some build automation I'm working on. |
|
@dany74q I'm not a maintainer of this repo unfortunately. @JordonPhillips I don't suppose you (or anyone else) could review this? :-) |
|
Hey @JordonPhillips, @kyleknap, @stealthycoin - would love to know if there's anything I can do to help get this in (: Thanks ! |
|
Ping @kyleknap, @stealthycoin, @nateprewitt (: Would love your help in getting this in - let me know if any further steps are required. |
|
Ping @kyleknap, @stealthycoin, @nateprewitt, @vz10, @joguSD (: Would love your help in getting this in. |
|
Any updates on this ? |
|
Pinging @kyleknap, @stealthycoin, @nateprewitt, @vz10, @joguSD, @edmorley, @raymyers as well. Thanks ! |
|
Hey guys, wondering if there's anything I can do to help push this through (: |
|
Friendly ping (: @stealthycoin, @kyleknap, @vz10, @kdaily, @kyleknap, @nateprewitt, @joguSD, @edmorley, @raymyers |
|
@dany74q I would like to see this merged too, however I am not an AWS employee/maintainer of this repo :-) |
|
Hi @max6746 thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and have put this issue (#3050) into the contribution ready stage. (described here). We are tracking this feature here on our project board. I will leave review comments on the issue about design (#3050 (comment)), and am marking this PR as a draft. A new PR can be opened that follows the design feedback from the issue, or this PR can be refreshed. |
|
Checking in on this PR — I think this one should be closed in favor of the newer #6993 (which still needs further review) as it addresses the design suggestions in #3050 (comment). |
Description of changes: Added support for generating pre-signed URL to put object to a specified bucket, with adding an extra parameter to the awscli s3 presign,
--client-methodwhich accepts valuesget_objectto generate pre-signed URL to retrieve object using HTTP GET request, andput_objectto generate pre-signed URL to upload object using HTTP PUT request.Also modified the description as well and added Examples for
aws s3 presign.Fixes #3050.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.