Skip to content

Added support for aws s3 presign for HTTP PUT request. And added Examples for aws s3 presign#3979

Closed
max6746 wants to merge 3 commits intoaws:developfrom
max6746:s3-presign-put
Closed

Added support for aws s3 presign for HTTP PUT request. And added Examples for aws s3 presign#3979
max6746 wants to merge 3 commits intoaws:developfrom
max6746:s3-presign-put

Conversation

@max6746
Copy link
Copy Markdown

@max6746 max6746 commented Mar 1, 2019

Description of changes: Added support for generating pre-signed URL to put object to a specified bucket, with adding an extra parameter to the awscli s3 presign, --client-method which accepts values get_object to generate pre-signed URL to retrieve object using HTTP GET request, and put_object to generate pre-signed URL to upload object using HTTP PUT request.
Also modified the description as well and added Examples for aws s3 presign.

Fixes #3050.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 1, 2019

Codecov Report

Merging #3979 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3979   +/-   ##
========================================
  Coverage    94.41%   94.41%           
========================================
  Files          188      188           
  Lines        14234    14234           
========================================
  Hits         13439    13439           
  Misses         795      795
Impacted Files Coverage Δ
awscli/customizations/s3/subcommands.py 97.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186d0a0...0895137. Read the comment docs.

@max6746 max6746 changed the title S3 presign put Added support for aws s3 presign for HTTP PUT request. And added Examples for aws s3 presign Mar 1, 2019
@max6746
Copy link
Copy Markdown
Author

max6746 commented Mar 4, 2019

@jamesls May you have a look and feedback over this will be helpful.

cc @kyleknap @JordonPhillips

@edmorley
Copy link
Copy Markdown

I was looking for something just like this earlier! I hope it ends up being merged :-)
(The PR has conflicts in presign.rst btw)

@raymyers
Copy link
Copy Markdown

raymyers commented Nov 7, 2019

Before seeing this I started making the same change. I hope this gets added, it would come in very handy to be able to generate pre-signed upload URLs for some build automation I'm working on.

@max6746
Copy link
Copy Markdown
Author

max6746 commented Dec 7, 2019

Thank You.
@edmorley Fixed conflicts.
@raymyers Please feel free to add more to it for improvements.

@dany74q
Copy link
Copy Markdown

dany74q commented Apr 21, 2020

Hey @edmorley, @raymyers, any chance this could be merged ?

Please let me know if there are further action items, I'll gladly contribute myself if @max6746 is unavailable.

Thanks !

@edmorley
Copy link
Copy Markdown

@dany74q I'm not a maintainer of this repo unfortunately.

@JordonPhillips I don't suppose you (or anyone else) could review this? :-)

@dany74q
Copy link
Copy Markdown

dany74q commented Apr 29, 2020

Hey @JordonPhillips, @kyleknap, @stealthycoin - would love to know if there's anything I can do to help get this in (:

Thanks !

@nateprewitt nateprewitt removed the request for review from JordonPhillips May 13, 2020 22:34
@dany74q
Copy link
Copy Markdown

dany74q commented May 21, 2020

Ping @kyleknap, @stealthycoin, @nateprewitt (:

Would love your help in getting this in - let me know if any further steps are required.

@dany74q
Copy link
Copy Markdown

dany74q commented May 31, 2020

Ping @kyleknap, @stealthycoin, @nateprewitt, @vz10, @joguSD (:

Would love your help in getting this in.
Thanks again !

@ivandres73
Copy link
Copy Markdown

Any updates on this ?
@max6746

@dany74q
Copy link
Copy Markdown

dany74q commented Oct 20, 2020

Pinging @kyleknap, @stealthycoin, @nateprewitt, @vz10, @joguSD, @edmorley, @raymyers as well.

Thanks !

@dany74q
Copy link
Copy Markdown

dany74q commented Oct 28, 2020

Hey guys, wondering if there's anything I can do to help push this through (:

@stealthycoin, @kyleknap, @vz10, @kdaily

@kdaily kdaily added the needs-review This issue or pull request needs review from a core team member. label Nov 3, 2021
@dany74q
Copy link
Copy Markdown

dany74q commented Dec 20, 2021

@edmorley
Copy link
Copy Markdown

@dany74q I would like to see this merged too, however I am not an AWS employee/maintainer of this repo :-)

@kdaily kdaily added feature-request A feature should be added or improved. and removed needs-review This issue or pull request needs review from a core team member. labels Apr 5, 2022
@stealthycoin
Copy link
Copy Markdown
Contributor

stealthycoin commented Apr 13, 2022

Hi @max6746 thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and have put this issue (#3050) into the contribution ready stage. (described here).

We are tracking this feature here on our project board.

I will leave review comments on the issue about design (#3050 (comment)), and am marking this PR as a draft. A new PR can be opened that follows the design feedback from the issue, or this PR can be refreshed.

@G-Rath
Copy link
Copy Markdown

G-Rath commented Dec 27, 2022

fwiw I've created #6993 which implements the feature per the design outlined in #3050, which supersedes this PR

@tim-finnigan
Copy link
Copy Markdown
Contributor

Checking in on this PR — I think this one should be closed in favor of the newer #6993 (which still needs further review) as it addresses the design suggestions in #3050 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community feature-request A feature should be added or improved. needs-rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please support generation of pre-signed URLs for S3 other than GET