Changing sudo pip to pip in readme.rst file.

[kshithijiyer]

fixes: #4175

[codecov-io]

Codecov Report

Merging #4224 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4224   +/-   ##
========================================
  Coverage    94.41%   94.41%           
========================================
  Files          188      188           
  Lines        14151    14151           
========================================
  Hits         13360    13360           
  Misses         791      791

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 069c7f9...3b083ef. Read the comment docs.

[merwok]

This probably won’t work, plus it’s not right in this part of the doc (it’s the same as the command just before).

pip install --user awscli could be an alternative that works without virtual env and without messing us the system (or being denied)

[kshithijiyer]

So should we just remove it or leave it as it is?

[merwok]

I don’t understand the question.

sudo pip install is bad, pip install won’t work. More thought is needed (e.g. with the install --user idea)

[kdaily]

Hi @kshithijiyer,

Apologies for the delay. We're cleaning up our backlog according to our new contribution process. I understand the sentiment of this change, and agree with @merwok that just dropping the sudo is probably not the best. I would possibly just drop this command entirely and rely on suggesting that users use a virtual environment. The logic here is that's what the AWS CLI v1 installation guide also suggests that, as well as a --user install. It does not direct users to install system-wide without using an operating system's package manager.

I think we should draw a better distinction between installing for development purposes here in the GitHub repository, and direct end users more towards the content in the Installation section of the AWS CLI User Guide.

Given the lag between opening this and now, I'm happy to make these changes, but I can leave it for you to do as well since it's a minimal change from what you already have. It might be better for you to open a new PR given the conflicts present from the long time; otherwise you'll need to rebase as well.

Let me know how you'd like to proceed!

[kdaily]

After some further discussion, we'd be even happier to remove the entire installation section, save for things that a developer would use, and redirect all end users to the User Guide installation section.

[tim-finnigan]

Given that we haven't heard back on this PR, I'm going to close it due to inactivity. As suggested above, there are broader improvements to the installation documentation that could be made here and I think that can be in a separate PR.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.41%. Comparing base (069c7f9) to head (3b083ef).
⚠️ Report is 6217 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4224   +/-   ##
========================================
  Coverage    94.41%   94.41%           
========================================
  Files          188      188           
  Lines        14151    14151           
========================================
  Hits         13360    13360           
  Misses         791      791           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.