Skip to content

Use repr to format s3 exceptions#6104

Closed
vin01 wants to merge 1 commit intoaws:developfrom
vin01:develop
Closed

Use repr to format s3 exceptions#6104
vin01 wants to merge 1 commit intoaws:developfrom
vin01:develop

Conversation

@vin01
Copy link
Copy Markdown

@vin01 vin01 commented Apr 19, 2021

Use of repr would ensure that exceptions without any error message (like MemoryError) are displayed properly to support debugging.

I recently debugged a MemoryError where error message would just say:

download failed: s3://remote to local-path

Having exception information in the log would be very helpful, it is not even displayed in the DEBUG logs currently.

I am not sure if using repr is the best approach here though, wdyt?

Use of repr would ensure that exceptions without any error message (like MemoryError) are displayed properly to support debugging
@stealthycoin
Copy link
Copy Markdown
Contributor

This needs an issue outlining the problem, if it gets sufficient traction we could move forward to the implementation phase.
#6828 details our new contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants