Add in flags argument for codeartifact login and alter pip tool to ho…#6633
Closed
whardier wants to merge 1 commit intoaws:developfrom
Closed
Add in flags argument for codeartifact login and alter pip tool to ho…#6633whardier wants to merge 1 commit intoaws:developfrom
whardier wants to merge 1 commit intoaws:developfrom
Conversation
…nor the secondary flag
kdaily
added
codeartifact login
customization
Contributor
|
Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. I updated the issue as well. |
Contributor
|
Thanks for creating this PR, but we decided to close this as not planned for reasons mentioned here: #6634 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting this in advance of writing tests. Providing a patch and looking for feedback.
This patch adds in flags argument for codeartifact login and alter pip tool to honor the secondary flag.
Issue #, if available:
#6634
Description of changes:
Offer a compatible feature update to codeartifact login that allows for flags to be associated with a tool. This allows for tools to alter how login is handled.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.