Skip to content

Add missing license fields in lambda and lambda-attributes crates#251

Merged
coltonweaver merged 1 commit into
aws:masterfrom
stanislav-tkach:missing-license-toml
Jan 19, 2021
Merged

Add missing license fields in lambda and lambda-attributes crates#251
coltonweaver merged 1 commit into
aws:masterfrom
stanislav-tkach:missing-license-toml

Conversation

@stanislav-tkach

@stanislav-tkach stanislav-tkach commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

Description of changes: License isn't specified in the lambda and lambda-attributes Cargo.toml files. The repository contains the LICENSE file, so I have used "Apache-2.0" from that file.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@rimutaka rimutaka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

@stanislav-tkach

Copy link
Copy Markdown
Contributor Author

Sorry to bother, but can this be fixed somehow? I'm using cargo-deny to control licenses of my project dependencies and this is kind of blocking me (EmbarkStudios/cargo-deny#250).

@Veetaha

Veetaha commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

cc @davidbarsky , looks like we can merge it right away

@coltonweaver coltonweaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution and apologies on the delay!

@coltonweaver coltonweaver merged commit d9998e7 into aws:master Jan 19, 2021
@stanislav-tkach stanislav-tkach deleted the missing-license-toml branch January 20, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants