Skip to content

Partially consumed stream checksum retry fix#3706

Merged
sbaluja merged 5 commits into
mainfrom
partially-consumed-stream-checksum
Feb 2, 2026
Merged

Partially consumed stream checksum retry fix#3706
sbaluja merged 5 commits into
mainfrom
partially-consumed-stream-checksum

Conversation

@sbaluja

@sbaluja sbaluja commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes:
Only save checksums for retries when the stream is at EOF.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbaluja sbaluja force-pushed the partially-consumed-stream-checksum branch from 0e7eca7 to e3c6e31 Compare February 2, 2026 16:26
@sbaluja sbaluja merged commit 85c8496 into main Feb 2, 2026
4 of 5 checks passed
@sbaluja sbaluja deleted the partially-consumed-stream-checksum branch February 2, 2026 19:13
kai-ion pushed a commit that referenced this pull request Feb 3, 2026
* add test for partially consumed stream checksum reuse

* Only save checksums when stream is at EOF

* Fix PartiallyConsumedStreamChecksumReuse test

* PartiallyConsumedStreamChecksumReuse - null check for stream before reading

* PartiallyConsumedStreamChecksumReuse - disable IMDS

---------

Co-authored-by: sbiscigl <sbiscigl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants