Skip to content

Use profile when creating Signin service when using login_session - #7217

Merged
alextwoods merged 1 commit into
masterfrom
alexwoo/login_creds_use_profile
Aug 5, 2026
Merged

Use profile when creating Signin service when using login_session#7217
alextwoods merged 1 commit into
masterfrom
alexwoo/login_creds_use_profile

Conversation

@alextwoods

Copy link
Copy Markdown
Contributor

Fix #7196 - credentials loaded from a login_session profile resolved the Signin client's configuration, such as region and endpoint_url, from the default profile instead of the profile that requested the credentials.

Motivation and Context

See #7196 - the LoginProfileCredentialsProviderFactory was creating its Signin service client without specifying any profile based overrides.

Modifications

Plumb the context's profile file/profile name through Signin client creation.

Testing

New and existing unit tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods
alextwoods requested a review from a team as a code owner August 3, 2026 21:01
@alextwoods alextwoods added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Aug 3, 2026
@alextwoods

Copy link
Copy Markdown
Contributor Author

Note - Added no-api-surface-area-change label since new method is package private and annotated with @SdkTestInternalApi

@alextwoods
alextwoods requested a review from RanVaknin August 3, 2026 21:10
@alextwoods
alextwoods added this pull request to the merge queue Aug 5, 2026
Merged via the queue into master with commit caf99d0 Aug 5, 2026
15 of 17 checks passed
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 5, 2026
@alextwoods
alextwoods deleted the alexwoo/login_creds_use_profile branch August 5, 2026 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

login_session credentials ignore the profile's region; SigninClient falls back to the default profile

2 participants