-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix dependency cve monitor list and add new workflow to verify list #7274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aws-sdk-java-automation
merged 1 commit into
master
from
hdavidh/fix-cve-monitor-worfklow
Aug 14, 2026
+55
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Ensures dependency-cve-monitor.yml stays in sync when modules are removed. | ||
| name: "Dependency CVE Monitor Verification" | ||
|
|
||
| on: | ||
| pull_request: | ||
| merge_group: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| verify-exclusion-list: | ||
| name: Verify CVE monitor exclusion list | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 2 | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - name: Validate -pl exclusion list against reactor modules | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
|
|
||
| WORKFLOW_FILE=".github/workflows/dependency-cve-monitor.yml" | ||
|
|
||
| # Extract the -pl argument from the workflow file | ||
| PL_LINE=$(grep -oP '(?<=-pl )\S+' "$WORKFLOW_FILE") | ||
| if [ -z "$PL_LINE" ]; then | ||
| echo "Could not find -pl argument in $WORKFLOW_FILE" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Parse individual module exclusions (remove leading '!') | ||
| EXCLUDED_MODULES=$(echo "$PL_LINE" | tr ',' '\n' | sed 's/^!//') | ||
|
|
||
| # Collect all reactor modules from root pom.xml (recursive through submodule poms) | ||
| REACTOR_MODULES=$(grep -ohP '(?<=<module>)[^<]+' pom.xml) | ||
|
|
||
| HAS_ERRORS=0 | ||
| while IFS= read -r MODULE; do | ||
| if ! echo "$REACTOR_MODULES" | grep -qx "$MODULE"; then | ||
| echo "::error::Module '$MODULE' is excluded in $WORKFLOW_FILE but does not exist in the Maven reactor (pom.xml)" | ||
| HAS_ERRORS=1 | ||
| fi | ||
| done <<< "$EXCLUDED_MODULES" | ||
|
|
||
| if [ $HAS_ERRORS -eq 1 ]; then | ||
| echo "" | ||
| echo "The -pl exclusion list in $WORKFLOW_FILE references modules that are no longer in the reactor." | ||
| echo "Please remove the stale entries from the exclusion list." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "All excluded modules are valid reactor modules." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not blocking: seems like this same list occurs is multiple places. We should move it to a single central location (e.g.
NON_PUBLISHED_MODULESor something) that can be updated once and all other build scripts can just reference itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this exact list is only present here. We have a similar exclusion list generated by
generate-modules-to-skip.shfor Maven and Docs, but that one dynamically derives it fromls test/, and also excludes (publishes) 5 test modules. This one can't easily do the same since it's a YAML input to a third-party GitHub Action.