chore(protocol_tests): updates for latest protocol tests#1770
Merged
chore(protocol_tests): updates for latest protocol tests#1770
Conversation
Contributor
Author
|
Taking a look at conflicting files. |
mtdowling
approved these changes
Dec 12, 2020
This commit fixes issues regarding the `@sparse` trait and null structure value serialization in the awsQuery, ec2Query, and restXml AWS protocols.
This commit fixes several issues when generating code for JSON related AWS protocols discovered when incorporating the newest AWS protocol tests. It contains the following fixes: * Fixes issues around the handling of the `@sparse` trait. * Fixes issues in serializing null values of structure members. * Fixes issues loading error codes for RPC JSON protocols. * Fixes deserializing document type payload responses.
kstich
force-pushed
the
protocol_test_fixes
branch
from
6938e1a to
b8d44ce
Compare
Contributor
Author
|
Conflicting file issues have been resolved. CI failing because of codegen package version change which will need smithy-lang/smithy-typescript#246 merged to succeed. |
trivikr
approved these changes
Dec 14, 2020
Member
There was a problem hiding this comment.
Verified that Java CI is successful when run locally with changes from smithy-lang/smithy-typescript#246
trivikr
changed the title
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will be paired with one to awslabs/smithy-typescript: smithy-lang/smithy-typescript#246
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
chore: update codegen plugin version and deps
fix: fix issues in query and xml serde
This commit fixes issues regarding the
@sparsetrait and nullstructure value serialization in the awsQuery, ec2Query, and restXml
AWS protocols.
fix: several issues in JSON protocol serde generation
This commit fixes several issues when generating code for JSON
related AWS protocols discovered when incorporating the newest AWS
protocol tests. It contains the following fixes:
@sparsetrait.chore: update generated protocol tests
fix: fix issues in some service models