fix: convert RST admonition to ADOC - #594
Merged
Merged
Conversation
nborges-aws
had a problem deploying
to
auto-approve
July 23, 2026 21:00 — with 
GitHub Actions
Failure
GitHub Actions
Failure
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
notgitika
approved these changes
Jul 23, 2026
notgitika
left a comment
notgitika
left a comment
Contributor
There was a problem hiding this comment.
LGTM but as a note maybe we should add tests/regression tests here? Could be a follow up or just a backlog item imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update
render_adoc.pyscript to handle two more conversion cases from RST to adoc:.. warning::→[WARNING]\n====\n...\n====:py:meth:bar→barmonospaceApplied in relevant call sites
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.