Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

fix: allow EnvManagerRole to access the s3 bucket that holds task's env files - #5760

Merged
mergify[bot] merged 3 commits into
aws:mainlinefrom
Lou1415926:fix/task/run/env/file/permission/to/envmanagerroel
Apr 8, 2024
Merged

fix: allow EnvManagerRole to access the s3 bucket that holds task's env files#5760
mergify[bot] merged 3 commits into
aws:mainlinefrom
Lou1415926:fix/task/run/env/file/permission/to/envmanagerroel

Conversation

@Lou1415926

Copy link
Copy Markdown
Contributor

Fixes: #5756

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Lou1415926
Lou1415926 requested a review from a team as a code owner April 5, 2024 23:33
@Lou1415926
Lou1415926 requested review from KollaAdithya and removed request for a team April 5, 2024 23:33
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (3b70f4c) to head (bc64e3c).

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5760      +/-   ##
============================================
+ Coverage     69.20%   70.03%   +0.83%     
============================================
  Files           289      303      +14     
  Lines         45008    46638    +1630     
  Branches          0      299     +299     
============================================
+ Hits          31147    32665    +1518     
- Misses        12279    12387     +108     
- Partials       1582     1586       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Apr 5, 2024

Copy link
Copy Markdown

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 57828 57688 +0.24
macOS (arm) 58892 58728 +0.28
linux (amd) 50708 50580 +0.25
linux (arm) 49984 49860 +0.25
windows (amd) 47764 47644 +0.25

@mergify
mergify Bot merged commit 23b124a into aws:mainline Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug]: Task Run Fails with Access Denied Error When Uploading .env File to S3

5 participants